ci/cd, fix sigint, LK_LOG -> std::cout/cerr, align with sdkl#1
Conversation
stephen-derosa
force-pushed
the
sderosa/ci-cd
branch
4 times, most recently
from
745fcb1 to
45ee795
Compare
LK_LOG -> std::cout/cerr downsample depth cloud
stephen-derosa
force-pushed
the
sderosa/ci-cd
branch
from
45ee795 to
819f7e3
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds CI workflows and build hardening while updating the RealSense publisher/recorder utilities (depth downsampling, improved error handling, and more flexible subscription targeting).
Changes:
- Add GitHub Actions workflows for CI builds, action pin checking, and license header checking.
- Update
realsense_publisherto decimate (downsample) depth frames and improve LiveKit track publish/push error handling. - Update
mcap_recorderto optionally subscribe to a configurable publisher identity (--publisher-id) and modernize logging/output.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
src/tests/realsense_to_mcap.cpp |
Refactors constants/handling and adds startup error handling for RealSense capture. |
src/realsense_publisher.cpp |
Adds depth decimation, switches logging to stdio, and updates LiveKit track publishing/pushing flows. |
src/mcap_recorder.cpp |
Adds --publisher-id option, switches logging to stdio, and updates callback wiring. |
README.md |
Adds a macOS sudo note. |
CMakeLists.txt |
Improves dependency discovery (LiveKit target selection, Protobuf CONFIG fallback) and removes spdlog linkage. |
.github/workflows/pin_check.yml |
Adds pinned-action verification workflow. |
.github/workflows/license_check.yml |
Adds license header checking workflow. |
.github/workflows/ci.yml |
Adds matrix build CI for macOS/Linux (x64/arm64) and dependency installation steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
volatile std::sig_atomic_t for sig int handling of running
stephen-derosa
force-pushed
the
sderosa/ci-cd
branch
from
182bcb0 to
281eb9a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/livekit-examples/realsense-cpp/sessions/04afd342-b605-459a-922b-b792e8571560 Co-authored-by: stephen-derosa <40528896+stephen-derosa@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stephen-derosa
changed the title
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Agent-Logs-Url: https://github.com/livekit-examples/realsense-cpp/sessions/089e7dbb-a627-4926-af63-9f8168b51874 Co-authored-by: stephen-derosa <40528896+stephen-derosa@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.