-
Notifications
You must be signed in to change notification settings - Fork 111
Add initial support for frame processor usage directly on tracks #671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1egoman
wants to merge
6
commits into
main
Choose a base branch
from
frame-processor-on-track
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5428532
feat: add initial support for frame processor usage directly on tracks
1egoman 15509be
fix: add optional chaining call to new *Cleared FrameProcessor methods
1egoman 4e9c0f1
fix: add missing changeset
1egoman 50e9551
fix: get rid of AudioStreamLike
1egoman cbad604
fix: run prettier
1egoman c1e6f43
fix: address devin issue
1egoman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/rtc-node': patch | ||
| --- | ||
|
|
||
| Add initial support for frame processor usage directly on tracks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,8 @@ | |
| "extends": "../../tsconfig.json", | ||
| "compilerOptions": { | ||
| "outDir": "dist", | ||
| "declarationDir": "dist" | ||
| "declarationDir": "dist", | ||
| "lib": ["es2015", "es2021.weakref"] | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this an ok addition to be making here? Or does there need to be a (in case it's useful, |
||
| }, | ||
| "include": ["src/**/*.ts"], | ||
| "exclude": ["src/**/*.test.ts", "vite.config.ts"] | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Missing processor metadata update in localTrackRepublished handler causes stale/empty metadata after reconnection
The PR adds
setRoom(this)calls inlocalTrackPublished,localTrackUnpublished,trackSubscribed, andtrackUnsubscribedhandlers to push processor metadata. However, thelocalTrackRepublishedhandler (fired during full reconnect when the SDK auto-republishes tracks) has no correspondingsetRoomcall or metadata push. After republish, the publication receives a new SID viapublication.updateInfo(newInfo)atroom.ts:567, but the track'sinfo.sid(used bypushProcessorMetadataToStreamattrack.ts:125) is never updated. This means any subsequent call topushProcessorMetadataToStream(e.g., when a new AudioStream is registered on the track after reconnection) will fail the lookuppublication.sid === trackSidattrack.ts:141because the publication now has the new SID while the track still has the old one. The processor receives emptyparticipantIdentityandpublicationSid.(Refers to lines 566-570)
Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.