Zero division fix (on leaflet.0.8-dev branch)#65
Closed
olzraiti wants to merge 3 commits intomakinacorpus:leaflet0.8-devfrom
Closed
Zero division fix (on leaflet.0.8-dev branch)#65olzraiti wants to merge 3 commits intomakinacorpus:leaflet0.8-devfrom
olzraiti wants to merge 3 commits intomakinacorpus:leaflet0.8-devfrom
Conversation
Contributor
Author
|
I updated the code to just fix with 1 instead of 0. Much more fool proof and works on every case. |
Contributor
Author
|
Closed by #79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the map was mounted to a node that's not in the DOM (which is not so rare for example in React environment), an error was thrown because
pattern.getComputedTextLength()resulted in 0, which caused a division by zero. I fixed the bug by checking if the map is rendered in the body.You can reproduce the bug like this: