Bug fix for potential zero dived by zero#79
Merged
gutard merged 1 commit intomakinacorpus:masterfrom Feb 7, 2020
Merged
Conversation
There is a bug with <this._path.getTotalLength() / alength> on line 92. I have a project where this._path.getTotalLength() is computed as 0 and alength also is computed as 0. Dividing 0 by 0 isn't possible in math. When this happens, it breaks the script from going any further. My proposed change resolves this problem. If this._path.getTotalLength() / alength is evaluated as NaN, it sets 'test' to 0, otherwise 'test' becomes the computed division.
Closed
|
Duplicate of #65 ? |
Contributor
Author
It looks like it, just a different approach to solve the problem. I hope that a solution is made soon. This is causing my team some issues in a project. |
|
Yup also looks a good fix but I wouldn't hold your breath waiting for it to get merged, there's been no activity for almost a year :( . Frustrating for me too as I'm waiting for #72 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug with
this._path.getTotalLength() / alengthon line 92. I have a project wherethis._path.getTotalLength()is computed as 0 andalengthalso is computed as 0. Dividing 0 by 0 isn't possible in math. When this happens, it breaks the script from going any further.My proposed change resolves this problem. If
this._path.getTotalLength() / alengthis evaluated as NaN, it setstestto 0, otherwisetestbecomes the computed division.