fix(heltec_t096): battery life improvement - fix lna_enable in LoRaFEMControl and code cleanup#2633
Open
NickDunklee wants to merge 1 commit into
Open
Conversation
- Set lna_enabled=true in LoRaFEMControl so KCT8103L enters RX/LNA mode (CTX=LOW) during receive instead of remaining in TX mode. Matching Heltec V4 default for the same chip. Reduces idle power draw during the dominant receive state. - Remove setRxModeEnableWhenMCUSleep() — dead code on nRF52. Unlike ESP32 deep sleep, nRF52 preserves GPIO state automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change for Heltec T096, it seemed to be consuming more power than what other nRF52-based boards do. Looks like a Heltec v4 optimization needed to be added. Also removed a few lines of dead code that doesn't apply to nRF52.
Fix:
Test:
Tested on Heltec T096 - battery life was significantly improved.