Skip to content

fix(heltec_t096): battery life improvement - fix lna_enable in LoRaFEMControl and code cleanup #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NickDunklee wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −12
Open

fix(heltec_t096): battery life improvement - fix lna_enable in LoRaFEMControl and code cleanup #2633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions variants/heltec_t096/LoRaFEMControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,6 @@ void LoRaFEMControl::setRxModeEnable(void)
}
}

void LoRaFEMControl::setRxModeEnableWhenMCUSleep(void)
{
digitalWrite(P_LORA_KCT8103L_PA_CSD, HIGH);
if (lna_enabled) {
digitalWrite(P_LORA_KCT8103L_PA_CTX, LOW);
} else {
digitalWrite(P_LORA_KCT8103L_PA_CTX, HIGH);
}
}

void LoRaFEMControl::setLNAEnable(bool enabled)
{
lna_enabled = enabled;
Expand Down
3 changes: 1 addition & 2 deletions variants/heltec_t096/LoRaFEMControl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@ class LoRaFEMControl
void setSleepModeEnable(void);
void setTxModeEnable(void);
void setRxModeEnable(void);
void setRxModeEnableWhenMCUSleep(void);
void setLNAEnable(bool enabled);
bool isLnaCanControl(void) { return lna_can_control; }
void setLnaCanControl(bool can_control) { lna_can_control = can_control; }

private:
bool lna_enabled = false;
bool lna_enabled = true;
bool lna_can_control = false;
};