Add macOS support to diskann-platform and diskann-disk#781
Add macOS support to diskann-platform and diskann-disk#781
Conversation
Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Co-authored-by: harsha-simhadri <5590673+harsha-simhadri@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 428 428
Lines 78417 78417
=======================================
Hits 69795 69795
Misses 8622 8622
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@copilot - apparently mutexes are larger on |
macOS mutexes are larger than on Linux/Windows. Increased the capacity from 16 to 64 bytes in inline_error_with_interior_mutability test to accommodate the larger Mutex<usize> on macOS. Co-authored-by: hildebrandmw <24898651+hildebrandmw@users.noreply.github.com>
Done! Increased the |
Complete macOS Support for DiskANN Workspace
This PR successfully implements comprehensive macOS support across the DiskANN workspace.
Summary of All Changes
diskann-platform (Initial Implementation)
cfg(target_os = "linux/windows/macos")cfg(unix)diskann-disk (Compilation Fix)
diskann-quantization (macOS Test Fix)
Verification
✅ Compilation: Entire workspace builds on x86_64-apple-darwin target
✅ Compilation: Entire workspace builds on x86_64-unknown-linux-gnu target
✅ Tests: All diskann-quantization tests pass (344 tests)
✅ Linting: Passes cargo fmt and cargo clippy
✅ Code Review: No issues found
The DiskANN workspace is now fully functional on macOS! 🎉
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.