Group dependabot updates to reduce repo noise#485
Conversation
https://docs.github.com/en/code-security/tutorials/secure-your-dependencies/optimizing-pr-creation-version-updates#grouping-related-dependencies-together refs apache/shiro#2621 Example Shiro dependabot file at the bottom they are using "groups" https://github.com/apache/shiro/blob/main/.github/dependabot.yml https://github.com/apache/sedona/blob/master/.github/dependabot.yml Only just got this merged for the pre-commit updates in the last day on Shiro and Sedona. I forgot to add the groups to my last mgem-list PR.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Dependabot configuration by implementing dependency grouping. The primary goal is to streamline the update process and minimize repository noise by combining multiple dependency updates into fewer, more manageable pull requests. This change applies to GitHub Actions, pre-commit hooks, and other general GitHub dependencies, making it easier to track and review security and maintenance updates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly implements grouping for dependabot updates to reduce repository noise. However, using the same group name for different package ecosystems will lead to identically titled pull requests, causing confusion. I've added suggestions to use unique and descriptive group names for each ecosystem to improve clarity.
| schedule: | ||
| interval: 'daily' | ||
| groups: | ||
| github-dependencies: |
There was a problem hiding this comment.
For clarity, it's better to use a group name that is specific to the package ecosystem. Using the same group name github-dependencies for bundler, github-actions, and pre-commit will result in pull requests with identical titles (e.g., 'Bump the github-dependencies group'), making it hard to distinguish between them. I suggest using a more descriptive name like bundler-dependencies here.
bundler-dependencies:| schedule: | ||
| interval: 'daily' | ||
| groups: | ||
| github-dependencies: |
| schedule: | ||
| interval: 'daily' | ||
| groups: | ||
| github-dependencies: |
https://docs.github.com/en/code-security/tutorials/secure-your-dependencies/optimizing-pr-creation-version-updates#grouping-related-dependencies-together
refs apache/shiro#2621
Example Shiro dependabot file at the bottom they are using "groups"
https://github.com/apache/shiro/blob/main/.github/dependabot.yml
https://github.com/apache/sedona/blob/master/.github/dependabot.yml
Only just got this merged for the pre-commit updates in the last day on Shiro and Sedona.
I forgot to add the groups to my last mgem-list PR.