Skip to content

Update multivcfanalyzer module#10137

Open
TCLamnidis wants to merge 14 commits intonf-core:masterfrom
TCLamnidis:update_multivcfanalyzer
Open

Update multivcfanalyzer module#10137
TCLamnidis wants to merge 14 commits intonf-core:masterfrom
TCLamnidis:update_multivcfanalyzer

Conversation

@TCLamnidis
Copy link
Contributor

@TCLamnidis TCLamnidis commented Feb 23, 2026

This PR:

  • Bumps multivcfanalyzer to the latest version.
  • Swaps to using bgzip for compressing the output snpAlignment.fasta.
  • Adds version topic.
  • Updates the nf-test to not use gzip anymore (not needed with latest version).
  • Updates the container links to use new multi-tool container that includes bgzip.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@TCLamnidis
Copy link
Contributor Author

Linting keeps failing with error

╭─ [✗] 1 Module Test Failed ───────────────────────────────────────────────────╮
│                  ╷                            ╷                              │
│ Module name      │ File path                  │ Test message                 │
│╶─────────────────┼────────────────────────────┼─────────────────────────────╴│
│ multivcfanalyzer │ modules/nf-core/multivcfa… │ wrong_version_output:        │
│                  │                            │ Versions topic output is not │
│                  │                            │ correctly formatted,         │
│                  │                            │ expected tuple               │
│                  │                            │ val("${task.process}"),      │
│                  │                            │ val('<tool>'),               │
│                  │                            │ eval("<version_command>") or │
│                  │                            │ tuple                        │
│                  │                            │ val("${task.process}"),      │
│                  │                            │ val('<tool>'),               │
│                  │                            │ val('<version>')             │
│                  ╵                            ╵                              │
╰──────────────────────────────────────────────────────────────────────────────╯

I do not understand this, since the version pickup of the module is following the examples in the Blog.

https://github.com/nf-core/modules/pull/10137/changes#diff-1b5e1ad4010a7076a06ed9675e4d34e7706bcc8303fdcd4d11b02e5dffad9da2R35-R36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant