feat(islandpath): migrate to topic: versions tuple#11435
Open
HReed1 wants to merge 3 commits intonf-core:masterfrom
Open
feat(islandpath): migrate to topic: versions tuple#11435HReed1 wants to merge 3 commits intonf-core:masterfrom
HReed1 wants to merge 3 commits intonf-core:masterfrom
Conversation
Contributor
Author
|
@nf-core-bot fix linting |
| prefix = task.ext.prefix ?: "${meta.id}" | ||
| // WARN: Version information not provided by tool on CLI. Please update this string when bumping container versions. | ||
| def VERSION = '1.0.6' | ||
| VERSION = '1.0.6' |
Member
There was a problem hiding this comment.
Suggested change
| VERSION = '1.0.6' |
mribeirodantas
requested changes
Apr 30, 2026
SPPearce
reviewed
May 1, 2026
Comment on lines
+22
to
+23
| args = task.ext.args ?: '' | ||
| prefix = task.ext.prefix ?: "${meta.id}" |
Contributor
There was a problem hiding this comment.
These should still be def, don't know why you are changing this here.
HReed1
force-pushed
the
stub-topics-islandpath
branch
from
44c26c3 to
ea3dc9a
Compare
Contributor
Author
|
Hey @SPPearce and @mribeirodantas — thanks for the reviews! I've pushed the fixes for both of your notes:
Let me know if we are good to go! |
SPPearce
requested changes
May 4, 2026
Comment on lines
+59
to
+64
| - '"1.0.6"': | ||
| type: string | ||
| description: The expression to obtain the version of the tool | ||
| 1.0.6: | ||
| type: string | ||
| description: The expression to obtain the version of the tool |
Contributor
There was a problem hiding this comment.
These don't need to be duplicated.
| - '"1.0.6"': | ||
| type: string | ||
| description: The expression to obtain the version of the tool | ||
| 1.0.6: |
| tuple val(meta), path("*.gff") , emit: gff | ||
| path "Dimob.log" , emit: log | ||
| path "versions.yml" , emit: versions | ||
| // WARN: Version information not provided by tool on CLI. Please update this string when bumping container versions. |
Contributor
There was a problem hiding this comment.
Personally I think this is best above, on the line above the conda instruction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11323
Migrates the
islandpathmodule to use the standardizedtopic: versionschannel tuple emission, removes legacyversions.ymlgeneration, and incorporates strict-syntax validations.