Skip to content

Conversation

@chaochaowong
Copy link
Contributor

@chaochaowong chaochaowong commented Nov 28, 2025

The hiphase module is used by pacvar. The update on emitting the phased bam file will not affect any of the processes in the pacvar pipeline.

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfill software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@chaochaowong chaochaowong self-assigned this Nov 28, 2025
@chaochaowong chaochaowong added enhancement New feature or request update module labels Nov 28, 2025
@chaochaowong chaochaowong changed the title Hiphase: update version to 1.5.0 and add phased bam file as an output Hiphase: bump to version 1.5.0; use wave container; add phased bam file as an output Dec 4, 2025
@chaochaowong chaochaowong changed the title Hiphase: bump to version 1.5.0; use wave container; add phased bam file as an output Hiphase: bump to version 1.5.0; use wave container; emit phased bam file Dec 9, 2025
Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@chaochaowong chaochaowong added this pull request to the merge queue Dec 30, 2025
Merged via the queue into nf-core:master with commit 62ca6e7 Dec 30, 2025
26 checks passed
@chaochaowong chaochaowong deleted the hiphase branch December 30, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants