fix: update isr configuration for package pages#1604
fix: update isr configuration for package pages#1604alexdln wants to merge 21 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📝 WalkthroughWalkthroughThe PR changes three areas: the Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
serhalp
left a comment
There was a problem hiding this comment.
This looks good to me, but seems like a defer-to-Daniel type of PR 😁
Thank you so much for digging into this gnarly issue! 🙌🏼
|
Thanks checking a few more options |
b23d693 to
4c41845
Compare
4c41845 to
5bbd4d1
Compare
5bbd4d1 to
6d53ce0
Compare
|
Main remaining problem: The server builds the page, but when the payload is loaded during hydration, it is empty and the user receives an error Well, all tested options work poorly
It could be improved if Nuxt had a more reliable mechanism for synchronizing HTML and payload (store it inside HTML and don't re-request on direct visit?). But this would leave a SEO problem So, we either need a completely custom server or disable fallback and accept the site's slow performance. For now, I've kept minimal changes to address some of the issues |
🔗 Linked issue
Resolves #1530 resolves #1267 resolves #1266
Not fixes #1194 #1534 #1558
🧭 Context
From the initial research:
📚 Description
🤞🤞🤞