Skip to content

fix: update isr configuration for package pages #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexdln wants to merge 21 commits into
base: main
Choose a base branch
from
+14 −24
Open

fix: update isr configuration for package pages #1604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
7069d10
chore: disable trailing slash rule
alexdln Feb 22, 2026
0a484dd
chore: enable trailing slash in nuxt config
alexdln Feb 22, 2026
f471f07
chore: enable trailing slash via middleware
alexdln Feb 22, 2026
28c6ff0
chore: improve trailing slash middleware
alexdln Feb 22, 2026
63f5f82
chore: improve version loading logic
alexdln Feb 22, 2026
2688747
chore: disable fallback for packages
alexdln Feb 22, 2026
b219252
chore: rewrite version resolver
alexdln Feb 22, 2026
9adacac
chore: disable extra caching for payload routes
alexdln Feb 22, 2026
a6a922d
fix: disable trailing slash middleware
alexdln Feb 23, 2026
65ced94
fix: disable isr rules for package pages
alexdln Feb 23, 2026
0dd72f3
fix: check single rule for all package pages
alexdln Feb 23, 2026
b28d476
fix: restore recharging path
alexdln Feb 23, 2026
f6df068
fix: add global fallback for package pages
alexdln Feb 23, 2026
3e9476e
fix: check payload fallback
alexdln Feb 23, 2026
2f6763b
fix: check payload fallback with exact rule
alexdln Feb 23, 2026
75d3d8d
fix: return null as payload fallback
alexdln Feb 23, 2026
0f52cb2
fix: return 400 error for initial payload
alexdln Feb 23, 2026
acdfd3a
fix: return 404 error for initial payload
alexdln Feb 23, 2026
8e06131
fix: disable fallback for package payloads
alexdln Feb 23, 2026
97d31e3
fix: disable fallback for package payloads
alexdln Feb 23, 2026
6d53ce0
fix: restore fallbacks for package pages
alexdln Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions app/composables/npm/useResolvedVersion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,17 @@ export function useResolvedVersion(
packageName: MaybeRefOrGetter<string>,
requestedVersion: MaybeRefOrGetter<string | null>,
) {
return useFetch(
() => {
return useAsyncData(
() => `resolved-version:${toValue(packageName)}:${toValue(requestedVersion) ?? 'latest'}`,
async () => {
const version = toValue(requestedVersion)
return version
? `https://npm.antfu.dev/${toValue(packageName)}@${version}`
: `https://npm.antfu.dev/${toValue(packageName)}`
},
{
transform: (data: ResolvedPackageVersion) => data.version,
const name = toValue(packageName)
const url = version
? `https://npm.antfu.dev/${name}@${version}`
: `https://npm.antfu.dev/${name}`
const data = await $fetch<ResolvedPackageVersion>(url)
return data.version
},
{ default: () => null },
)
}
15 changes: 3 additions & 12 deletions app/pages/package/[[org]]/[name].vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,18 +194,9 @@ const { data: skillsData } = useLazyFetch<SkillsListResponse>(
const { data: packageAnalysis } = usePackageAnalysis(packageName, requestedVersion)
const { data: moduleReplacement } = useModuleReplacement(packageName)

const {
data: resolvedVersion,
status: versionStatus,
error: versionError,
} = await useResolvedVersion(packageName, requestedVersion)

if (
versionStatus.value === 'error' &&
versionError.value?.statusCode &&
versionError.value.statusCode >= 400 &&
versionError.value.statusCode < 500
) {
const { data: resolvedVersion } = await useResolvedVersion(packageName, requestedVersion)

if (resolvedVersion.value === null) {
throw createError({
statusCode: 404,
statusMessage: $t('package.not_found'),
Expand Down
5 changes: 1 addition & 4 deletions nuxt.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,10 @@ export default defineNuxtConfig({
},
},
// pages
'/package/:name': getISRConfig(60, { fallback: 'html' }),
'/package/**': getISRConfig(60, { fallback: 'html' }),
'/package/:name/_payload.json': getISRConfig(60, { fallback: 'json' }),
'/package/:name/v/:version': getISRConfig(60, { fallback: 'html' }),
'/package/:name/v/:version/_payload.json': getISRConfig(60, { fallback: 'json' }),
'/package/:org/:name': getISRConfig(60, { fallback: 'html' }),
'/package/:org/:name/_payload.json': getISRConfig(60, { fallback: 'json' }),
'/package/:org/:name/v/:version': getISRConfig(60, { fallback: 'html' }),
'/package/:org/:name/v/:version/_payload.json': getISRConfig(60, { fallback: 'json' }),
// infinite cache (versioned - doesn't change)
'/package-code/**': { isr: true, cache: { maxAge: 365 * 24 * 60 * 60 } },
Expand Down
Loading