fix(envconfig): rename CLUSTER_DOMAIN env var to FLAGD_CLUSTER_DOMAIN

[kuznero]

Summary

• Prefix the cluster domain environment variable with FLAGD_ to maintain consistency with other flagd-related configuration options

Context

This is a follow-up to #789 which added configurable cluster domain support. The environment variable naming should be consistent with other flagd-related options.

Changes

• Rename CLUSTER_DOMAIN to FLAGD_CLUSTER_DOMAIN in envconfig

Signed-off-by: Roman Kuznetsov roku@lix.one

[gemini-code-assist]

Summary of Changes

Hello @kuznero, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the consistency of environment variable naming within the flagd configuration. By prefixing the cluster domain environment variable with FLAGD_, the change aligns it with existing flagd-specific settings, making the configuration more intuitive and maintainable. This is a refinement to previously introduced configurable cluster domain support.

Highlights

• Environment Variable Renaming: The CLUSTER_DOMAIN environment variable has been renamed to FLAGD_CLUSTER_DOMAIN to ensure consistency with other flagd-related configuration options.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request renames the CLUSTER_DOMAIN environment variable to FLAGD_CLUSTER_DOMAIN to improve consistency with other flagd-related configuration options. The change is valid, however, to further improve consistency within the EnvConfig struct itself, I've suggested renaming the struct field from ClusterDomain to FlagdClusterDomain to align with its corresponding environment variable.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.33%. Comparing base (499661e) to head (0c04704).
⚠️ Report is 85 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #792       +/-   ##
===========================================
- Coverage   86.51%   72.33%   -14.19%     
===========================================
  Files          19       30       +11     
  Lines        1587     1923      +336     
===========================================
+ Hits         1373     1391       +18     
- Misses        173      484      +311     
- Partials       41       48        +7     

Files with missing lines	Coverage Δ
internal/common/flagdproxy/flagdproxy.go	90.23% <100.00%> (ø)

... and 26 files with indirect coverage changes

Flag	Coverage Δ
unit-tests	72.33% <100.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[kuznero]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly renames the CLUSTER_DOMAIN environment variable to FLAGD_CLUSTER_DOMAIN for consistency, updating the EnvConfig struct and its usages. The changes are correct and align with the PR's goal. My review includes one comment on a related field that appears to be unused, suggesting a cleanup to improve code maintainability.

[kuznero]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly renames the CLUSTER_DOMAIN environment variable to FLAGD_CLUSTER_DOMAIN to improve consistency. The changes are applied correctly across the configuration, implementation, and test files. I've added one comment regarding potentially unused code that is being touched by this change, which could be an opportunity for a small cleanup.

[kuznero]

@beeme1mr, this PR is a follow up PR from #789. If you have a moment could you please review/approve it?

[kuznero]

@toddbaert , any chance this can be merged?

[kuznero]

@beeme1mr can you recommend who else can approve this PR?

[toddbaert]

Yep! Thanks @kuznero . Sorry for the delay.