change: set capability favorites to false, for unadjusted clients

[AlexAndBear]

Description

Related Issue

• Works towards Favorites feature broken on mobile clients after re-enabling capability flag #2682

Motivation and Context

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation added

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 13 complexity · 5 duplication

Metric	Results
Complexity	13
Duplication	5

View in Codacy

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

_{TIP This summary will be updated as you push new changes.}

[codacy-production]

Pull Request Overview

The PR implements a global hardcoded change to the 'favorites' capability, setting it to false. While the title suggests this is for 'unadjusted clients', the implementation affects all clients, which constitutes a potential breaking change and a major logic contradiction.

Although Codacy marks the PR as 'Up to Standards', the modified file services/frontend/pkg/revaconfig/config.go is flagged as an uncovered complex file with a significant complexity increase (+13). The lack of unit tests and an empty PR description are major concerns that prevent a safe merge. This configuration change should be made configurable and verified with tests before proceeding.

About this PR

• The PR description is almost entirely empty (Motivation and Context, testing details, and checklists are incomplete). Furthermore, no unit tests were added to ensure this configuration change propagates correctly.

1 comment outside of the diff

services/frontend/pkg/revaconfig/config.go

_{line 390-446 🟡 MEDIUM RISK}
This 56-line block of configuration logic is identical to logic in services/sharing/pkg/revaconfig/config.go. Large duplications like this should be refactored into a shared utility to reduce maintenance burden and prevent configuration drift.

Test suggestions

• Verify that the generated frontend configuration explicitly sets the favorites capability to false
• Generate unit tests for the revaconfig package to cover the configuration mapping logic

Prompt proposal for missing tests

Consider implementing these tests if applicable:
1. Verify that the generated frontend configuration explicitly sets the favorites capability to false
2. Generate unit tests for the `revaconfig` package to cover the configuration mapping logic

_{TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback}

[codacy-production]

_{🟡 MEDIUM RISK}

The favorites capability is now hardcoded to false for all clients, contradicting the PR title's suggestion that this is targeted only at 'unadjusted' clients. If some clients still need this feature enabled, this global change will break it. Additionally, this file's complexity has increased (+13) without any test coverage, making this change fragile. Consider adding a Favorites boolean field to the Config struct to allow for better control and generate unit tests to cover the mapping logic.

See Complexity in Codacy
See Coverage in Codacy