Skip to content

change: set capability favorites to false, for unadjusted clients #2731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexAndBear wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

change: set capability favorites to false, for unadjusted clients #2731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2b179c
change: introduce new capability favorites_v2
AlexAndBear May 11, 2026
c8e26c1
change: omit not needed favorites_v2 capability
AlexAndBear May 11, 2026
4a92228
bump web commit id
AlexAndBear May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .woodpecker.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# The test runner source for UI tests
WEB_COMMITID=86cc6c0119bf551619699ae80d43a9be4fe3aae2
WEB_COMMITID=909f9915b39cb736467d02a9afdc7e9bfa99de53
WEB_BRANCH=main

2 changes: 1 addition & 1 deletion services/frontend/pkg/revaconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func FrontendConfigFromStruct(cfg *config.Config, logger log.Logger) (map[string
"tags": true,
"archivers": archivers,
"app_providers": appProviders,
"favorites": true,
"favorites": false,
Copy link
Copy Markdown

@codacy-production codacy-production Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The favorites capability is now hardcoded to false for all clients, contradicting the PR title's suggestion that this is targeted only at 'unadjusted' clients. If some clients still need this feature enabled, this global change will break it. Additionally, this file's complexity has increased (+13) without any test coverage, making this change fragile. Consider adding a Favorites boolean field to the Config struct to allow for better control and generate unit tests to cover the mapping logic.

See Complexity in Codacy
See Coverage in Codacy

"full_text_search": cfg.FullTextSearch,
}

Expand Down