Skip to content

feat: use makefile target for image update#73267

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
raelga:feat/image-updater-makefile-target
Jan 14, 2026
Merged

feat: use makefile target for image update#73267
openshift-merge-bot[bot] merged 2 commits intoopenshift:masterfrom
raelga:feat/image-updater-makefile-target

Conversation

@raelga
Copy link
Copy Markdown
Contributor

@raelga raelga commented Jan 8, 2026

This pull request simplifies the process for running the image updater by removing manual build steps and directory changes, and instead running the updater through a make target. This streamlines the workflow, reduces the chance for errors and allows changes without updating the job.

Image updater workflow simplification:

  • Replaced manual cd into tooling/image-updater and explicit make build/binary execution with a single make image-updater update command, passing the verbosity via an environment variable.
  • Removed directory navigation commands to keep the script in the root directory, simplifying script flow.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2026
@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 8, 2026

cc @hbhushan3

@openshift-ci openshift-ci Bot requested review from hbhushan3 and roivaz January 8, 2026 14:30
@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 8, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 8, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-delete-expired-development-resource-groups

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: job(s): periodic-ci-Azure-ARO-HCP-main-periodic-delete-expired-development-resource-groups either don't exist or were not found to be affected, and cannot be rehearsed

@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 13, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-delete-expired-development-resource-groups

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: job(s): periodic-ci-Azure-ARO-HCP-main-periodic-delete-expired-development-resource-groups either don't exist or were not found to be affected, and cannot be rehearsed

@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 13, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 13, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 13, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Rael Garcia <rael@redhat.com>
Signed-off-by: Rael Garcia <rael@redhat.com>
@raelga raelga force-pushed the feat/image-updater-makefile-target branch from e67af8f to 025e1a8 Compare January 13, 2026 14:00
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@raelga: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 13, 2026

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hbhushan3
Copy link
Copy Markdown
Member

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-image-updater-image-updater-tooling

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@hbhushan3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Copy link
Copy Markdown
Contributor

@roivaz roivaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga, roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@raelga raelga requested a review from roivaz January 14, 2026 08:57
@raelga
Copy link
Copy Markdown
Contributor Author

raelga commented Jan 14, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@raelga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 14, 2026

@raelga: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit eb2b66a into openshift:master Jan 14, 2026
11 checks passed
dhensel-rh pushed a commit to dhensel-rh/release that referenced this pull request Feb 19, 2026
* feat: use makefile target for image update

Signed-off-by: Rael Garcia <rael@redhat.com>

* debug: increase verbosity

Signed-off-by: Rael Garcia <rael@redhat.com>

---------

Signed-off-by: Rael Garcia <rael@redhat.com>
@raelga raelga deleted the feat/image-updater-makefile-target branch March 31, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants