Skip to content

stackrox(perfscale): pin ocp version#73276

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:masterfrom
stackrox:rox-perfscale-pin-ocpversion
Jan 27, 2026
Merged

stackrox(perfscale): pin ocp version#73276
openshift-merge-bot[bot] merged 5 commits intoopenshift:masterfrom
stackrox:rox-perfscale-pin-ocpversion

Conversation

@davdhacs
Copy link
Copy Markdown
Contributor

@davdhacs davdhacs commented Jan 8, 2026

We want to test with an un-changing OCP version so that differences in metrics are because of stackrox changes and not openshift changes.

https://docs.ci.openshift.org/docs/architecture/ci-operator/#testing-with-an-existing-openshift-release

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2026
@davdhacs
Copy link
Copy Markdown
Contributor Author

davdhacs commented Jan 8, 2026

/pj-rehearse

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@davdhacs
Copy link
Copy Markdown
Contributor Author

davdhacs commented Jan 8, 2026

/pj-rehearse ack
it is running, and orion is reporting a possible regression
/cc @mtodor
This pins to stable ocp

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot requested a review from mtodor January 8, 2026 21:16
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 8, 2026
@davdhacs
Copy link
Copy Markdown
Contributor Author

davdhacs commented Jan 8, 2026

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2026
version: "4.19"
release:
channel: stable
version: "4.20"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh. I would pin it to strict patch. If we use stable channel we could still get instability from 4.20.z updates. @davdhacs What do you think?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. How about 4.20.8 (Dec 12, then 4.20.9 was released Jan 9)?

@davdhacs
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 13, 2026
@davdhacs
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@davdhacs
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@davdhacs: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@davdhacs
Copy link
Copy Markdown
Contributor Author

Log Snippet

INFO[2026-01-19T16:39:57Z] Requesting latest release from https://api.integration.openshift.com/api/upgrades_info/graph?arch=amd64&channel=stable-4.20
INFO[2026-01-19T16:39:57Z] Resolved release latest to quay.io/openshift-release-dev/ocp-release@sha256:91606a5f04331ed3293f71034d4f480e38645560534805fe5a821e6b64a3f203
INFO[2026-01-19T16:40:24Z] Importing release 4.20.8 created at 2025-12-11 12:32:49 +0000 UTC with 192 images to tag release:latest ...
INFO[2026-01-19T16:42:02Z] Imported release 4.20.8 created at 2025-12-11 12:32:49 +0000 UTC with 192 images to tag release:latest

Build Log URL

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_release/73276/rehearse-73276-periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test/2013290298842550272/build-log.txt

@davdhacs davdhacs requested a review from mtodor January 19, 2026 21:52
@davdhacs
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 19, 2026
@davdhacs
Copy link
Copy Markdown
Contributor Author

I think I should wait until stable-4.20 reaches a new version and then we can verify this still gets a 4.20.8 ocp instead of later.
https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable-4.20/
https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/fast-4.20/

@davdhacs
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@davdhacs
Copy link
Copy Markdown
Contributor Author

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/73276/rehearse-73276-periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test/2014381945957388288

INFO[2026-01-22T16:59:57Z] Imported release 4.20.8 created at 2025-12-11 12:32:49 +0000 UTC with 192 images to tag release:latest 

It was updated to 4.20.10 Jan 21:
https://mirror.openshift.com/pub/openshift-v4/x86_64/clients/ocp/stable-4.20/

So this verifies the pinning works.
@mtodor can you review this for merge? I think it is ready now.

@davdhacs
Copy link
Copy Markdown
Contributor Author

davdhacs commented Jan 26, 2026

/pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test

I'm re-running it as an extra sanity check. I don't think the stream would get the wrong version more than 12 hours after the update, but I'd like to be certain it still get the 4.20.8 version now, days later.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 26, 2026

@davdhacs: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test 2d49b0c link unknown /pj-rehearse periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@davdhacs
Copy link
Copy Markdown
Contributor Author

Confirmed it stayed on 4.20.8 for the re-run yesterday (https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/73276/rehearse-73276-periodic-ci-stackrox-stackrox-nightlies-perf-scale-24nodes-scale-scannerv4-test/2015833599240048640):

INFO[2026-01-26T17:08:03Z] Imported release 4.20.8 created at 2025-12-11 12:32:49 +0000 UTC with 192 images to tag release:latest 

@davdhacs
Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@davdhacs: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtodor
Copy link
Copy Markdown
Contributor

mtodor commented Jan 27, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davdhacs, mtodor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit f004842 into openshift:master Jan 27, 2026
16 of 17 checks passed
richardsonnick pushed a commit to richardsonnick/release that referenced this pull request Feb 10, 2026
* stackrox(perfscale): pin ocp version

* pin perfscale to 4.20.8

* unquoted
richardsonnick pushed a commit to richardsonnick/release that referenced this pull request Feb 18, 2026
* stackrox(perfscale): pin ocp version

* pin perfscale to 4.20.8

* unquoted
dhensel-rh pushed a commit to dhensel-rh/release that referenced this pull request Feb 19, 2026
* stackrox(perfscale): pin ocp version

* pin perfscale to 4.20.8

* unquoted
weinliu pushed a commit to weinliu/release that referenced this pull request Mar 6, 2026
* stackrox(perfscale): pin ocp version

* pin perfscale to 4.20.8

* unquoted
sdodson pushed a commit to sdodson/release that referenced this pull request Mar 8, 2026
* stackrox(perfscale): pin ocp version

* pin perfscale to 4.20.8

* unquoted
tareqalayan pushed a commit to tareqalayan/release that referenced this pull request Mar 13, 2026
* stackrox(perfscale): pin ocp version

* pin perfscale to 4.20.8

* unquoted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants