GCP-484: Write project IDs to SHARED_DIR before resource creation#76425
GCP-484: Write project IDs to SHARED_DIR before resource creation#76425cristianoveiga wants to merge 1 commit intoopenshift:mainfrom
Conversation
Move project ID writes to immediately after gcloud projects create so the deprovision step can clean up orphaned projects even if the provision step is aborted mid-execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@cristianoveiga: This pull request references GCP-484 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristianoveiga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-gke |
|
@cristianoveiga: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@cristianoveiga: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
|| true)Problem
When the
gke-provisionstep is aborted mid-execution (e.g., job cancelled or timed out), the deprovision step cannot clean up orphaned GCP projects because project IDs were only written to SHARED_DIR at the end of the script.Evidence: provision build log
Test plan
Jira: https://issues.redhat.com/browse/GCP-484
🤖 Generated with Claude Code