-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: add e2e conformance test step for Konflux on OpenShift #76428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| approvers: | ||
| - amisstea | ||
| - avi-biton | ||
| - cuipinghuo | ||
| - dheerajodha | ||
| - flacatus | ||
| - gbenhaim | ||
| - hmariset | ||
| - ifireball | ||
| - jinqi7 | ||
| - kasemalem | ||
| - kelchen123 | ||
| - psturc | ||
| - tisutisu | ||
| - yftacherzog |
25 changes: 25 additions & 0 deletions
25
ci-operator/step-registry/konflux-ci/e2e-tests/konflux-ci-e2e-tests-commands.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -o nounset | ||
| set -o errexit | ||
| set -o pipefail | ||
|
|
||
| SECRETS_DIR=/usr/local/ci-secrets/konflux-ci-konflux-ci-e2e-tests-credentials | ||
|
|
||
| # Source the e2e env template to pick up defaults | ||
| source test/e2e/e2e.env.template | ||
|
|
||
| # Override e2e test credentials | ||
| export GH_TOKEN GH_ORG QUAY_DOCKERCONFIGJSON RELEASE_CATALOG_TA_QUAY_TOKEN GITHUB_TOKEN MY_GITHUB_ORG | ||
| GH_TOKEN=$(cat "${SECRETS_DIR}/github-token") | ||
| GH_ORG=$(cat "${SECRETS_DIR}/github-org") | ||
| QUAY_DOCKERCONFIGJSON=$(cat "${SECRETS_DIR}/quay-dockerconfigjson") | ||
| RELEASE_CATALOG_TA_QUAY_TOKEN=$(cat "${SECRETS_DIR}/release-catalog-ta-quay-token") | ||
| GITHUB_TOKEN="${GH_TOKEN}" | ||
| MY_GITHUB_ORG="${GH_ORG}" | ||
| # Not running with upstream dependencies — this is OCP | ||
| unset TEST_ENVIRONMENT | ||
|
|
||
| # Deploy test resources and run E2E conformance tests | ||
| ./test/e2e/run-e2e.sh | ||
|
|
21 changes: 21 additions & 0 deletions
21
ci-operator/step-registry/konflux-ci/e2e-tests/konflux-ci-e2e-tests-ref.metadata.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "path": "konflux-ci/e2e-tests/konflux-ci-e2e-tests-ref.yaml", | ||
| "owners": { | ||
| "approvers": [ | ||
| "amisstea", | ||
| "avi-biton", | ||
| "cuipinghuo", | ||
| "dheerajodha", | ||
| "flacatus", | ||
| "gbenhaim", | ||
| "hmariset", | ||
| "ifireball", | ||
| "jinqi7", | ||
| "kasemalem", | ||
| "kelchen123", | ||
| "psturc", | ||
| "tisutisu", | ||
| "yftacherzog" | ||
| ] | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
ci-operator/step-registry/konflux-ci/e2e-tests/konflux-ci-e2e-tests-ref.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ref: | ||
| as: konflux-ci-e2e-tests | ||
| cli: latest | ||
| commands: konflux-ci-e2e-tests-commands.sh | ||
| from: src | ||
| timeout: 1h | ||
| grace_period: 1m | ||
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 200Mi | ||
| credentials: | ||
| - mount_path: /usr/local/ci-secrets/konflux-ci-konflux-ci-e2e-tests-credentials | ||
| name: konflux-ci-konflux-ci-e2e-tests-credentials | ||
| namespace: test-credentials | ||
| documentation: |- | ||
| Deploys test resources and runs E2E conformance test suite from | ||
| konflux-ci/konflux-ci. Run after konflux-ci-install-operator. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recall during standup you mentioned the tests could take 1hr 30min or more; should the timeout be increased? If most of the time is for cluster provisioning it should be fine but just checking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That includes the cluster claim process and operator installation which have their own timeouts. The actual test suite has a 30m timeout declared within the
run-e2e.shscript so the timeout here just needed to be a bit bigger than than. 1h is overkill but I think that's ok - the tests should fail faster.