SPLAT-2668: hypershift/aws/ccm: enable optional managed security group conformance job#77567
SPLAT-2668: hypershift/aws/ccm: enable optional managed security group conformance job#77567mtulio wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@mtulio: This pull request references SPLAT-2587 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtulio: This pull request references SPLAT-2587 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
This is expected to fail as the feature is not merged on hypershift: /pj-rehearse pull-ci-openshift-hypershift-main-e2e-conformance-aws-ccm-nlb-sg |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/assign enxebre |
|
@mtulio: This pull request references SPLAT-2587 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mtulio
changed the title
|
@mtulio: This pull request references SPLAT-2668 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtulio: This pull request references SPLAT-2668 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mtulio
force-pushed
the
splat-2587-hypershift-conformance-nlb
branch
from
2110c4c to
ddf4d3a
Compare
|
job is passing: rehearse-77567-pull-ci-openshift-hypershift-main-e2e-conformance-aws-ccm-nlb-sg #2042066510754615296 I just fixed the "ci metadata" with EOL fixes (nit): /pj-rehearse ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
rehearsals-ack
|
/assign @muraee |
mtulio
changed the title
|
/assign @enxebre |
|
@enxebre @muraee WDYT to create a periodic and an alert to Slack (my teams channel) to this job, so i can monitor it closely. Are you ok to add one more job for that purpose? I will remove it as part of getting complete the task https://redhat.atlassian.net/browse/SPLAT-2668 |
|
/lgtm |
openshift-ci
Bot
added
lgtm
|
New changes are detected. LGTM label has been removed. |
|
Adding the periiodic with alerts to SPLAT channel to monitor closely the progress of NLB+SG feature |
mtulio
force-pushed
the
splat-2587-hypershift-conformance-nlb
branch
from
4294b2f to
f1a1529
Compare
|
/pj-rehearse periodic-ci-openshift-release-main-hypershift-4.22-hypershift-conformance-aws-ccm-nlb-sg |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
subset PR has been filed to isolate changes #78757 |
mtulio
force-pushed
the
splat-2587-hypershift-conformance-nlb
branch
from
f1a1529 to
957491c
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdd AWS CCM conformance job entries (one optional main job, two monthly periodics) that use the ChangesAWS CCM Conformance tests
Prowgen Slack reporter
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mtulio, vr4manta The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@mtulio: This pull request references SPLAT-2668 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/pj-rehearse periodic-ci-openshift-hpershift-main-hypershift-4.23-e2e-aws-ovn-conformance-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: job(s): periodic-ci-openshift-hpershift-main-hypershift-4.23-e2e-aws-ovn-conformance-ccm either don't exist or were not found to be affected, and cannot be rehearsed |
mtulio
force-pushed
the
splat-2587-hypershift-conformance-nlb
branch
from
957491c to
1be2a84
Compare
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
mtulio
force-pushed
the
splat-2587-hypershift-conformance-nlb
branch
from
1be2a84 to
f5086a5
Compare
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm periodic-ci-openshift-hypershift-release-4.23-periodics-e2e-aws-ovn-conformance-ccm-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml (1)
161-170: ⚡ Quick winStagger the weekly schedules to avoid synchronized capacity spikes.
Line 161 and Line 170 both use
@weekly, so both jobs trigger together. Using offset explicit cron times reduces quota contention and flake risk onhypershift-aws.Suggested change
- as: e2e-aws-ovn-conformance-ccm - cron: '@weekly' + cron: 13 2 * * 1 steps: cluster_profile: hypershift-aws @@ - as: e2e-aws-ovn-conformance-ccm-techpreview - cron: '@weekly' + cron: 43 2 * * 1 steps: cluster_profile: hypershift-aws🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml` around lines 161 - 170, Two jobs in this snippet share the same schedule (`@weekly`), causing them to run simultaneously; update one of the cron fields to an explicit, staggered weekly time to avoid capacity spikes. Locate the job with workflow: hypershift-aws-conformance and the job labeled as: e2e-aws-ovn-conformance-ccm-techpreview and replace one of their cron: '@weekly' entries with an explicit cron expression (e.g., a different day/time) so the runs are offset; ensure the new cron is still weekly and document the chosen offset in a short comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml`:
- Around line 161-170: Two jobs in this snippet share the same schedule
(`@weekly`), causing them to run simultaneously; update one of the cron fields to
an explicit, staggered weekly time to avoid capacity spikes. Locate the job with
workflow: hypershift-aws-conformance and the job labeled as:
e2e-aws-ovn-conformance-ccm-techpreview and replace one of their cron: '@weekly'
entries with an explicit cron expression (e.g., a different day/time) so the
runs are offset; ensure the new cron is still weekly and document the chosen
offset in a short comment.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 58dc910b-bdc7-46b7-b22a-3eb7d3eabf90
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.23-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yamlci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Analysing the failed test But CCM is creating it correctly - Load Balancer is created (CCM logs): The problem is test is not retrying enough times and/or correctly. We fixed similar issue in upstream tests[1], but this needs to be ported on downstream - while OTE/downstream is not using upstream library[2]. All tests not using this fix are failing: [1] https://redhat.atlassian.net/browse/OCPBUGS-83399 The bug https://redhat.atlassian.net/browse/OCPBUGS-85414 has been filed to track this issue. |
Create a dedicated conformance job enabling managed security group feature of CCM for NLB, so that we can validate the feature on hypershift at PR openshift/hypershift#7460 hypershift/aws/ccm: enable periodic for managed security group test move hypershift-e2e-ccm job to correct presubmit place create TP job for CCM to meet API enalbe notifications for e2e-aws-hypershift rename presubmit
mtulio
force-pushed
the
splat-2587-hypershift-conformance-nlb
branch
from
8fb5448 to
690c8f5
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
As described in the comment #77567 (comment), the new job is expected to fail as it blocked by OCPBUGS-85414, and we need this job to validate the fix on the PR, currently WIP on openshift/cluster-cloud-controller-manager-operator#462 /pj-rehearse ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/test config check-gh-automation |
5 participants
Create a dedicated conformance job enabling managed security group feature of CCM for NLB, so that we can validate the feature on hypershift at PR
openshift/hypershift#7460
The new job presubmit job for hypershift project, overrides the TESTS_SKIPS from conformance workflow. A dedicated job has been created to prevent disruption in existing monitoring, while we can validate the PR individually. Once the tests are validated on Hypershift, and feature deliverable and stable, we will remove this one, and the TEST_SKIPS for
AWSServiceLBNetworkSecurityGrouphttps://redhat.atlassian.net/browse/SPLAT-2587
https://redhat.atlassian.net/browse/SPLAT-2668
This PR updates OpenShift CI configuration for the hypershift project to add targeted conformance jobs that validate AWS Cloud Controller Manager (CCM) Network Load Balancer (NLB) behavior when managed security groups are enabled.
Practical changes
Adds an optional Hypershift conformance presubmit (ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml):
Adds two monthly periodic conformance jobs for release-4.23 (ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.23__periodics.yaml):
Adds Slack reporting (ci-operator/config/openshift/hypershift/.config.prowgen):
Purpose and follow-ups from PR discussion
Files changed (key CI configs)