Skip to content

ocp-virt-validation-checkup: add 4.22 jobs #79041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orenc1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ocp-virt-validation-checkup: add 4.22 jobs #79041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions ...v/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
build_root:
image_stream_tag:
name: release
namespace: openshift
tag: rhel-9-release-golang-1.24-openshift-4.22
images:
items:
- dockerfile_path: ci/Dockerfile.ci
to: ocp-virt-validation-checkup
releases:
latest:
candidate:
product: ocp
stream: nightly
version: "4.22"
resources:
'*':
limits:
memory: 4Gi
requests:
cpu: 100m
memory: 600Mi
tests:
- as: unit
commands: make test
container:
from: src
- as: e2e-aws
steps:
cluster_profile: aws-virtualization
env:
BASE_DOMAIN: cnv-ci.syseng.devcluster.openshift.com
CNV_VERSION: "4.22"
test:
- ref: interop-tests-deploy-cnv
- as: run-validation-checkup
cli: latest
commands: make ci-validate
dependencies:
- env: OCP_VIRT_VALIDATION_IMAGE
name: ocp-virt-validation-checkup
env:
- default: gp3
name: STORAGE_CLASS
from: src
resources:
requests:
cpu: 100m
memory: 600Mi
workflow: cnv-e2e-ipi-aws
zz_generated_metadata:
branch: release-4.22
org: openshift-cnv
repo: ocp-virt-validation-checkup
105 changes: 105 additions & 0 deletions ...validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22__periodics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
build_root:
image_stream_tag:
name: release
namespace: openshift
tag: rhel-9-release-golang-1.24-openshift-4.22
releases:
latest:
release:
channel: stable
Copy link
Copy Markdown
Contributor

@rlobillo rlobillo May 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is stable channel already available for OCP4.22?

Copy link
Copy Markdown
Contributor Author

@orenc1 orenc1 May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, i'll fix

version: "4.22"
resources:
'*':
limits:
memory: 4Gi
requests:
cpu: 100m
memory: 600Mi
tests:
- as: e2e-azure
cron: 0 20 * * 0
steps:
cluster_profile: azure-virtualization
env:
BASE_DOMAIN: cnv-devel.azure.devcluster.openshift.com
COMPUTE_NODE_TYPE: Standard_D4s_v5
ODF_BACKEND_STORAGE_CLASS: managed-csi
ODF_OPERATOR_CHANNEL: stable-4.21
Copy link
Copy Markdown
Contributor

@rlobillo rlobillo May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is stable-4.21 available? main is using stable-4.20 I believe because it was not available at the time the job was created

Copy link
Copy Markdown
Contributor Author

@orenc1 orenc1 May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ODF 4.21 is now generally available, yes

observers:
enable:
- observers-resource-watch
test:
- as: install-cnv
cli: latest
commands: |
curl -L https://github.com/openshift-cnv/cnv-ci/tarball/master -o /tmp/cnv-ci.tgz
mkdir -p /tmp/cnv-ci
tar -xvzf /tmp/cnv-ci.tgz -C /tmp/cnv-ci --strip-components=1
cd /tmp/cnv-ci
make update_pull_secret set_imagedigestmirrorset deploy_cnv
oc patch hco kubevirt-hyperconverged -n openshift-cnv --type=json -p='[{"op": "add", "path": "/spec/defaultCPUModel", "value": "Broadwell"}]'
credentials:
- mount_path: /var/run/cnv-ci-brew-pull-secret
name: cnv-ci-brew-pull-secret
namespace: test-credentials
- mount_path: /var/run/cnv-ci-konflux-pull-secret
name: konflux-pull-secret
namespace: test-credentials
env:
- default: '|7820aea2-0d75-11e7-9259-28d244ea5a6d.hhav.f63e13'
name: BREW_IMAGE_REGISTRY_USERNAME
- default: /var/run/cnv-ci-brew-pull-secret/token
name: BREW_IMAGE_REGISTRY_TOKEN_PATH
- default: openshift-virtualization+konflux_ro_bot
name: KONFLUX_REGISTRY_USERNAME
- default: /var/run/cnv-ci-konflux-pull-secret/token
name: KONFLUX_REGISTRY_TOKEN_PATH
- default: "4.22"
name: OCP_VERSION
- default: "4.22"
name: CNV_VERSION
- default: /tmp/artifacts
name: ARTIFACTS_DIR
- default: openshift-cnv
name: TARGET_NAMESPACE
- default: "false"
name: PRODUCTION_RELEASE
from: src
resources:
requests:
cpu: 100m
memory: 600Mi
timeout: 1h0m0s
- ref: hypershift-kubevirt-install-odf
- as: run-validation-checkup
cli: latest
commands: |
export CSV_NAME=$(oc get csv -n openshift-cnv -o json | jq -r '.items[] | select(.metadata.name | startswith("kubevirt-hyperconverged")).metadata.name')
export OCP_VIRT_VALIDATION_IMAGE=$(oc get csv -n ${TARGET_NAMESPACE} $CSV_NAME -o json | jq -r '.spec.relatedImages[] | select(.name | contains("ocp-virt-validation-checkup")).image')
make ci-validate || true # Once https://issues.redhat.com/browse/CNV-71660 is fixed, remove "|| true"
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Don’t mask validation failures with || true.

Line [79] turns real test failures into green jobs, which removes the periodic’s regression signal.

Suggested change 
-        make ci-validate || true # Once https://issues.redhat.com/browse/CNV-71660 is fixed, remove "|| true"
+        make ci-validate
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
make ci-validate || true # Once https://issues.redhat.com/browse/CNV-71660 is fixed, remove "|| true"
make ci-validate
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-cnv/ocp-virt-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22__periodics.yaml`
at line 79, The job currently masks test failures by appending "|| true" to the
"make ci-validate" invocation; remove the "|| true" so that "make ci-validate"
returns a failing exit code when validations fail (restore proper failure
propagation for the periodic). Locate the invocation string "make ci-validate ||
true" in the job spec and change it to "make ci-validate" (or otherwise let the
shell exit non-zero), keeping the existing comment about CNV-71660 if you want
to track the issue separately.

env:
- default: "false"
name: DRY_RUN
- default: 360m
name: OCP_VIRT_VALIDATION_TIMEOUT
- default: ocs-storagecluster-ceph-rbd-virtualization
name: STORAGE_CLASS
- default: test_id:1780|test_id:1783|test_id:1513|test_id:1514
name: TEST_SKIPS
- default: openshift-cnv
name: TARGET_NAMESPACE
- default: /tmp/artifacts
name: ARTIFACTS_DIR
from: src
resources:
requests:
cpu: 100m
memory: 600Mi
timeout: 6h30m0s
workflow: ipi-azure
timeout: 9h0m0s
zz_generated_metadata:
branch: release-4.22
org: openshift-cnv
repo: ocp-virt-validation-checkup
variant: periodics
84 changes: 84 additions & 0 deletions ...-validation-checkup/openshift-cnv-ocp-virt-validation-checkup-release-4.22-periodics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
periodics:
- agent: kubernetes
cluster: build01
cron: 0 20 * * 0
decorate: true
decoration_config:
skip_cloning: true
timeout: 9h0m0s
extra_refs:
- base_ref: release-4.22
org: openshift-cnv
repo: ocp-virt-validation-checkup
labels:
ci-operator.openshift.io/cloud: azure4
ci-operator.openshift.io/cloud-cluster-profile: azure-virtualization
ci-operator.openshift.io/variant: periodics
ci.openshift.io/generator: prowgen
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: periodic-ci-openshift-cnv-ocp-virt-validation-checkup-release-4.22-periodics-e2e-azure
spec:
containers:
- args:
- --gcs-upload-secret=/secrets/gcs/service-account.json
- --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
- --lease-server-credentials-file=/etc/boskos/credentials
- --report-credentials-file=/etc/report/credentials
- --secret-dir=/secrets/ci-pull-credentials
- --target=e2e-azure
- --variant=periodics
command:
- ci-operator
env:
- name: HTTP_SERVER_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
image: quay-proxy.ci.openshift.org/openshift/ci:ci_ci-operator_latest
imagePullPolicy: Always
name: ""
ports:
- containerPort: 8080
name: http
resources:
requests:
cpu: 10m
volumeMounts:
- mountPath: /etc/boskos
name: boskos
readOnly: true
- mountPath: /secrets/ci-pull-credentials
name: ci-pull-credentials
readOnly: true
- mountPath: /secrets/gcs
name: gcs-credentials
readOnly: true
- mountPath: /secrets/manifest-tool
name: manifest-tool-local-pusher
readOnly: true
- mountPath: /etc/pull-secret
name: pull-secret
readOnly: true
- mountPath: /etc/report
name: result-aggregator
readOnly: true
serviceAccountName: ci-operator
volumes:
- name: boskos
secret:
items:
- key: credentials
path: credentials
secretName: boskos-credentials
- name: ci-pull-credentials
secret:
secretName: ci-pull-credentials
- name: manifest-tool-local-pusher
secret:
secretName: manifest-tool-local-pusher
- name: pull-secret
secret:
secretName: registry-pull-credentials
- name: result-aggregator
secret:
secretName: result-aggregator
Loading