OCM-23826 | feat: cs-rosa-hcp-backup-restore-integration-main#79043
OCM-23826 | feat: cs-rosa-hcp-backup-restore-integration-main#79043andclt wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andclt The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-integration-ocm-fvt-periodic-cs-rosa-hcp-backup-restore-integration-main |
|
@andclt: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
WalkthroughA new CI configuration file is added for ROSA E2E backup/restore integration testing on OpenShift Online, defining base images, resource constraints, and a scheduled ocmtest job that runs within a podman environment. ChangesROSA E2E Integration Test Pipeline Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml (1)
57-58: ⚡ Quick winUnpinned
latesttag on theocmcitest runner image.
quay.io/redhat-services-prod/ocmci/ocmci:latestis a floating tag. A breaking change pushed to that image will silently change job behavior on the next run, with no git history trail. Consider pinning to a digest or a versioned tag.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml` around lines 57 - 58, The job is using a floating image tag "quay.io/redhat-services-prod/ocmci/ocmci:latest" (used by the ocmtest command for job cs-rosa-hcp-backup-restore-integration-main); replace the floating tag with a stable reference by pinning to a versioned tag or image digest (e.g., change ":latest" to a specific semver tag or to "@sha256:<digest>") so the job image is immutable and future runs are reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml`:
- Around line 42-50: The inner bash heredoc should fail fast if sourcing
credentials fails; update the heredoc that writes to "${podman_env_file}" (the
block starting with env -i bash --norc --noprofile << EOF >
"${podman_env_file}") so that the inner shell enables errexit — either add
bash's -e flag to that bash invocation or insert a leading set -e as the first
command in the heredoc before the source lines (the lines referencing source
/usr/local/cs-qe-credentials/ocm-tokens and source
/usr/local/cs-qe-credentials/jira-cred) so missing or faulty credential files
cause an immediate failure.
---
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml`:
- Around line 57-58: The job is using a floating image tag
"quay.io/redhat-services-prod/ocmci/ocmci:latest" (used by the ocmtest command
for job cs-rosa-hcp-backup-restore-integration-main); replace the floating tag
with a stable reference by pinning to a versioned tag or image digest (e.g.,
change ":latest" to a specific semver tag or to "@sha256:<digest>") so the job
image is immutable and future runs are reproducible.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 92407cd7-f333-4e28-9133-578baab46193
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml
| env -i bash --norc --noprofile << EOF > "${podman_env_file}" | ||
| export AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-cred | ||
| export SHARED_VPC_AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-shared-vpc-credentials | ||
| export ENABLE_JIRA_REPORTING=true | ||
| export JOB_LINK="${JOB_LINK}" | ||
| source /usr/local/cs-qe-credentials/ocm-tokens | ||
| source /usr/local/cs-qe-credentials/jira-cred | ||
| env | grep -v '^_=' | ||
| EOF |
There was a problem hiding this comment.
Add set -e to the inner bash invocation to fail fast on sourcing errors.
If either source /usr/local/cs-qe-credentials/ocm-tokens or source /usr/local/cs-qe-credentials/jira-cred fails (e.g., file missing or contains a syntax error), the inner bash process will silently continue, env will emit only the vars set before the failure, and podman run will proceed with incomplete credentials — producing a confusing downstream authentication failure rather than an immediate clear error.
🛡️ Proposed fix
- env -i bash --norc --noprofile << EOF > "${podman_env_file}"
+ env -i bash -e --norc --noprofile << EOF > "${podman_env_file}"
export AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-cred📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| env -i bash --norc --noprofile << EOF > "${podman_env_file}" | |
| export AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-cred | |
| export SHARED_VPC_AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-shared-vpc-credentials | |
| export ENABLE_JIRA_REPORTING=true | |
| export JOB_LINK="${JOB_LINK}" | |
| source /usr/local/cs-qe-credentials/ocm-tokens | |
| source /usr/local/cs-qe-credentials/jira-cred | |
| env | grep -v '^_=' | |
| EOF | |
| env -i bash -e --norc --noprofile << EOF > "${podman_env_file}" | |
| export AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-cred | |
| export SHARED_VPC_AWS_SHARED_CREDENTIALS_FILE=/credentials/aws-shared-vpc-credentials | |
| export ENABLE_JIRA_REPORTING=true | |
| export JOB_LINK="${JOB_LINK}" | |
| source /usr/local/cs-qe-credentials/ocm-tokens | |
| source /usr/local/cs-qe-credentials/jira-cred | |
| env | grep -v '^_=' | |
| EOF |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-integration.yaml`
around lines 42 - 50, The inner bash heredoc should fail fast if sourcing
credentials fails; update the heredoc that writes to "${podman_env_file}" (the
block starting with env -i bash --norc --noprofile << EOF >
"${podman_env_file}") so that the inner shell enables errexit — either add
bash's -e flag to that bash invocation or insert a leading set -e as the first
command in the heredoc before the source lines (the lines referencing source
/usr/local/cs-qe-credentials/ocm-tokens and source
/usr/local/cs-qe-credentials/jira-cred) so missing or faulty credential files
cause an immediate failure.
|
@andclt: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
This PR is for migrating
cs-rosa-hcp-backup-restore-integration-mainFVT to Prow.This PR adds a Prow CI configuration for the ROSA HCP backup and restore integration test pipeline in the OpenShift Online repository. The new configuration file defines a scheduled job (
ocm-fvt-periodic-cs-rosa-hcp-backup-restore-integration-main) that runs daily at 8 AM UTC to validate ROSA HCP backup and restore functionality. The job executes OCM tests in a nested-podman container environment with access to AWS credentials and JIRA ticket reporting, ensuring that backup and restore operations work correctly for ROSA Hosted Control Planes as part of the regular CI verification process.