ROSAENG-855: Add presubmit e2e smoke tests for rosa-e2e PRs by dustman9000 · Pull Request #79049 · openshift/release

dustman9000 · 2026-05-08T15:12:42Z

Summary

Add presubmit e2e smoke tests for rosa-e2e PRs that validate code changes against both ROSA HCP and Classic STS clusters in parallel.

e2e-rosa-hcp-smoke: Provisions HCP cluster, runs Importance:Critical tests
e2e-rosa-classic-smoke: Provisions Classic STS cluster, runs Importance:Critical && Platform:Classic tests
Both use run_if_changed to trigger only on Go code, test, or Containerfile changes
Uses rosa-e2e-01 cluster profile, stable channel, OCP 4.22

Jira: https://redhat.atlassian.net/browse/ROSAENG-855

Test plan

make jobs generates presubmit job definitions
After merge, open a test PR to rosa-e2e with a code change and verify both jobs trigger
Verify docs-only PRs do not trigger the e2e jobs

Summary

This PR modifies the OpenShift CI configuration for the openshift-online/rosa-e2e repository by adding two presubmit end-to-end smoke test jobs that run in parallel to validate code changes against critical ROSA scenarios.

Changes Made

Added two presubmit jobs to the rosa-e2e main CI pipeline:
- e2e-rosa-hcp-smoke — provisions a Hosted Control Plane (HCP) cluster and runs tests labeled Importance:Critical.
- e2e-rosa-classic-smoke — provisions a Classic STS cluster and runs tests labeled Importance:Critical && Platform:Classic.
Both jobs:
- Use the rosa-e2e-01 cluster profile.
- Use the stable channel and OCM staging environment.
- Set OPENSHIFT_VERSION to 4.21 (commit corrected from 4.22).
- Deploy with 2 replicas.
- Reference existing workflows (rosa-e2e-hcp and rosa-e2e-classic).
- Share environment variables and differ by HOSTED_CP and LABEL_FILTER.

Trigger Logic

Both jobs use run_if_changed to limit triggering to substantive changes:
- Files under pkg/
- Tests under test/
- Containerfile, go.mod, and go.sum
This is intended to avoid running the E2E smoke tests for docs-only PRs.

Metadata & Validation

Jira: ROSAENG-855 (bot noted the issue is valid but warned the Jira target version is missing/invalid).
The author ran make jobs to generate presubmit job definitions.
A rehearse command was invoked for the HCP smoke job; full verification requires opening a test PR to confirm both jobs trigger and confirming docs-only PRs skip them.

Add two presubmit jobs that run critical smoke tests against HCP and Classic STS clusters when Go code or test files change in a PR: - e2e-rosa-hcp-smoke: Importance:Critical tests on HCP cluster - e2e-rosa-classic-smoke: Importance:Critical && Platform:Classic on Classic STS cluster Both use run_if_changed to skip docs-only PRs, stable channel 4.22, and the rosa-e2e-01 cluster profile. Jira: https://redhat.atlassian.net/browse/ROSAENG-855

openshift-ci-robot · 2026-05-08T15:12:46Z

@dustman9000: This pull request references ROSAENG-855 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add presubmit e2e smoke tests for rosa-e2e PRs that validate code changes against both ROSA HCP and Classic STS clusters in parallel.

e2e-rosa-hcp-smoke: Provisions HCP cluster, runs Importance:Critical tests

e2e-rosa-classic-smoke: Provisions Classic STS cluster, runs Importance:Critical && Platform:Classic tests

Both use run_if_changed to trigger only on Go code, test, or Containerfile changes

Uses rosa-e2e-01 cluster profile, stable channel, OCP 4.22

Jira: https://redhat.atlassian.net/browse/ROSAENG-855

Test plan

make jobs generates presubmit job definitions

After merge, open a test PR to rosa-e2e with a code change and verify both jobs trigger

Verify docs-only PRs do not trigger the e2e jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-05-08T15:13:12Z

Walkthrough

Adds two new CI e2e smoke test job entries—e2e-rosa-hcp-smoke and e2e-rosa-classic-smoke—to the OpenShift ROSA E2E CI config. Both are gated by run_if_changed, use cluster_profile: rosa-e2e-01, share several env vars, and differ by HOSTED_CP, LABEL_FILTER, and referenced workflow.

Changes

E2E Smoke Test Jobs

Layer / File(s)	Summary
CI Test Configuration / Triggers `ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`	Adds two jobs `e2e-rosa-hcp-smoke` and `e2e-rosa-classic-smoke` with `run_if_changed` on `pkg/`, `test/`, `Containerfile`, `go.mod`, `go.sum`.
Cluster Profile / Shared Env `ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`	Both jobs set `cluster_profile: rosa-e2e-01` and environment variables: `CHANNEL_GROUP: stable`, `OCM_LOGIN_ENV: staging`, `OPENSHIFT_VERSION: "4.21"`, `REPLICAS: "2"`.
Variant-specific Env / Workflow `ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`	HCP job: `HOSTED_CP: "true"`, `LABEL_FILTER: Importance:Critical`, `workflow: rosa-e2e-hcp`. Classic job: `HOSTED_CP: "false"`, `LABEL_FILTER: Importance:Critical && Platform:Classic`, `workflow: rosa-e2e-classic`.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: adding presubmit E2E smoke tests for ROSA PRs. It clearly summarizes the primary purpose of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Check not applicable. PR adds CI/CD job configuration (YAML), not Ginkgo test code. The check applies to Ginkgo test titles, which are absent.
Test Structure And Quality	✅ Passed	PR adds only YAML workflow configuration entries (e2e-rosa-hcp-smoke, e2e-rosa-classic-smoke) referencing existing workflows. No new Ginkgo test code files included, making the check inapplicable.
Microshift Test Compatibility	✅ Passed	This PR adds CI/CD configuration entries, not actual Ginkgo test code. The check applies only to new test implementations, which are absent here.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR adds CI job configuration for existing test workflows, not new Ginkgo e2e test code. Custom check applies only to new Ginkgo tests, making it inapplicable here.
Topology-Aware Scheduling Compatibility	✅ Passed	This PR modifies CI-Operator test configuration, not deployment manifests, operator code, or controllers. The topology-aware scheduling check does not apply to CI pipeline configurations.
Ote Binary Stdout Contract	✅ Passed	PR only modifies YAML CI configuration, not Go source code. OTE Binary Stdout Contract check applies to Go process-level code. No code changes present, so check is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds CI configuration only (YAML test job entries in openshift/release). No new Ginkgo e2e tests are added—the check requires new test code.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-05-08T15:14:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift-online/rosa-e2e/OWNERS~~ [dustman9000]
~~ci-operator/jobs/openshift-online/rosa-e2e/OWNERS~~ [dustman9000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml`:
- Around line 44-56: The run_if_changed regex used in the CI config (the two
occurrences of run_if_changed: ^(pkg/|test/|Containerfile|go\.(mod|sum))) is too
permissive; update both instances so they end-anchor and require .go files under
pkg/ and test/ and exact matches for Containerfile and go.mod/go.sum (e.g.
change the pattern to require pkg/.*\.go and test/.*\.go and append $ anchors
accordingly). Modify the lines containing run_if_changed so the new regex
enforces pkg/ and test/ to match only .go files and prevents suffix matches for
Containerfile and go.mod/go.sum.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3bfbbb89-6d30-468b-967b-12dcfcaa7e3a

📥 Commits

Reviewing files that changed from the base of the PR and between a2c45a6 and 7e61725.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml

dustman9000 · 2026-05-08T16:06:42Z

/pj-rehearse pull-ci-openshift-online-rosa-e2e-main-e2e-rosa-hcp-smoke

openshift-merge-bot · 2026-05-08T16:06:45Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-05-08T17:06:35Z

@dustman9000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift-online/rosa-e2e/main/e2e-rosa-hcp-smoke	`7e61725`	link	unknown	`/pj-rehearse pull-ci-openshift-online-rosa-e2e-main-e2e-rosa-hcp-smoke`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

dustman9000 · 2026-05-08T19:01:27Z

/pj-rehearse ci/rehearse/openshift-online/rosa-e2e/main/e2e-rosa-hcp-smoke

openshift-merge-bot · 2026-05-08T19:01:30Z

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-05-08T19:06:22Z

@dustman9000: job(s): ci/rehearse/openshift-online/rosa-e2e/main/e2e-rosa-hcp-smoke either don't exist or were not found to be affected, and cannot be rehearsed

dustman9000 · 2026-05-08T19:24:44Z

/pj-rehearse pull-ci-openshift-online-rosa-e2e-main-e2e-rosa-hcp-smoke

dustman9000 · 2026-05-08T19:50:16Z

/pj-rehearse pull-ci-openshift-online-rosa-e2e-main-e2e-rosa-hcp-smoke

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2026

openshift-ci Bot requested review from bmeng and jfrazierRedHat May 8, 2026 15:14

coderabbitai Bot reviewed May 8, 2026

View reviewed changes

Comment thread ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main.yaml

Fix smoke test version: use 4.21 (latest stable in staging)

5576e9d

Conversation

dustman9000 commented May 8, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary

Changes Made

Trigger Logic

Metadata & Validation

Uh oh!

openshift-ci-robot commented May 8, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

coderabbitai Bot commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated Code Review Effort

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dustman9000 commented May 8, 2026

Uh oh!

openshift-merge-bot Bot commented May 8, 2026

Uh oh!

openshift-ci Bot commented May 8, 2026

Uh oh!

dustman9000 commented May 8, 2026

Uh oh!

openshift-merge-bot Bot commented May 8, 2026

Uh oh!

openshift-merge-bot Bot commented May 8, 2026

Uh oh!

dustman9000 commented May 8, 2026

Uh oh!

dustman9000 commented May 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dustman9000 commented May 8, 2026 •

edited by atlassian Bot

Loading

openshift-ci-robot commented May 8, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented May 8, 2026 •

edited

Loading