Skip to content

CNF-22982: Add renovate.json to excluded files for cluster-group-upgr…#79052

Open
fontivan wants to merge 1 commit intoopenshift:mainfrom
fontivan:sskeard/cnf-22982-update-renovate-configuration-talm
Open

CNF-22982: Add renovate.json to excluded files for cluster-group-upgr…#79052
fontivan wants to merge 1 commit intoopenshift:mainfrom
fontivan:sskeard/cnf-22982-update-renovate-configuration-talm

Conversation

@fontivan
Copy link
Copy Markdown
Contributor

@fontivan fontivan commented May 8, 2026

…ades-operator ci triggers

  • the renovate.json file should not cause any prow tests to run as it is only used for Mintmaker configuration

Assisted-by: Cursor/auto
AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0
For more information on AI attribution statements, see: https://aiattribution.github.io/

Summary

Adds renovate.json to the list of excluded files in CI trigger configurations for the OpenShift KNI cluster-group-upgrades-operator component. This prevents Prow CI jobs from running when only renovate.json is modified, since this file is used exclusively for Mintmaker configuration and does not require any test validation.

Changes

Updated the skip_if_only_changed glob patterns across all cluster-group-upgrades-operator CI configuration files to exclude renovate.json:

  • Main branch configuration (openshift-kni-cluster-group-upgrades-operator-main.yaml): Updated skip patterns in base CI job config, integration, and security test sections
  • Release branch configurations (4.12, 4.14, 4.16, 4.18, 4.19, 4.20, 4.21, 4.22): Applied consistent skip pattern updates across corresponding CI job and test definitions

The changes ensure that both primary CI jobs and optional test stages (integration, security) consistently skip execution when only renovate configuration files are modified.

…ades-operator ci triggers

- the renovate.json file should not cause any prow tests to run as it is only used for Mintmaker configuration

Assisted-by: Cursor/auto
AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0
For more information on AI attribution statements, see: https://aiattribution.github.io/
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 8, 2026

@fontivan: This pull request references CNF-22982 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

…ades-operator ci triggers

  • the renovate.json file should not cause any prow tests to run as it is only used for Mintmaker configuration

Assisted-by: Cursor/auto
AI-attribution: AIA,Primarily AI-generated,Human-initiated,Reviewed,Cursor/auto,v1.0
For more information on AI attribution statements, see: https://aiattribution.github.io/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7fb710b0-3e68-4feb-8608-06d4988ff999

📥 Commits

Reviewing files that changed from the base of the PR and between 3bf4299 and d627c24.

⛔ Files ignored due to path filters (9)
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.12-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.14-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.16-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.18-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.19-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.20-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.21-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.22-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (9)
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-main.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.12.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.14.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.16.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.18.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.19.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.20.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.21.yaml
  • ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-release-4.22.yaml

Walkthrough

This PR updates CI configuration across eight release branches and main to add renovate.json to skip_if_only_changed regex patterns, ensuring changes limited to Renovate configuration files do not trigger CI pipelines.

Changes

CI Job Configuration: Renovate Skip Patterns

Layer / File(s) Summary
Skip Pattern Updates
ci-operator/config/openshift-kni/cluster-group-upgrades-operator/openshift-kni-cluster-group-upgrades-operator-main.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.12.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.14.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.16.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.18.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.19.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.20.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.21.yaml, openshift-kni-cluster-group-upgrades-operator-release-4.22.yaml
skip_if_only_changed regex patterns extended to include renovate\.json across all CI job definitions (top-level, ci-job, integration, and security jobs), preventing Renovate-only commits from triggering unnecessary builds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding renovate.json to excluded files for cluster-group-upgrades-operator CI triggers, which matches the actual changes across all modified YAML configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only CI configuration YAML files (skip_if_only_changed patterns), not Ginkgo test code. No test names present to assess. Check is not applicable.
Test Structure And Quality ✅ Passed PR only modifies CI config YAML files, not Ginkgo test code. Check for test code quality is not applicable.
Microshift Test Compatibility ✅ Passed PR contains only CI configuration YAML changes. No new Ginkgo e2e tests or test code added, so MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR contains only CI configuration YAML changes (adding renovate.json to skip patterns). The SNO Test Compatibility check applies to new Ginkgo e2e tests, but no test code was added.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only CI configuration files. It contains no deployment manifests, operator code, controllers, or scheduling constraints that the topology check targets.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration files. No Go source code changes. OTE Binary Stdout Contract check applies only to Go test binaries, not YAML configs.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR modifies only CI config YAML files; no Ginkgo e2e tests are added. The custom check for IPv6/disconnected network compatibility only applies when new tests are added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fontivan
Copy link
Copy Markdown
Contributor Author

fontivan commented May 8, 2026

/cc @jc-rh @by2waysprojects

@openshift-ci openshift-ci Bot requested review from by2waysprojects and jc-rh May 8, 2026 16:02
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fontivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2026
@openshift-ci openshift-ci Bot requested review from pixelsoccupied and vitus133 May 8, 2026 16:03
@fontivan
Copy link
Copy Markdown
Contributor Author

fontivan commented May 8, 2026

/pj-rehearse auto-ack

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

@fontivan: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@fontivan: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.14-ci-index openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.14-ci-job openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.14-images openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.14-integration openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.20-ci-index openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.20-ci-job openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.20-images openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.20-integration openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.20-security openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.19-ci-index openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.19-ci-job openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.19-images openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.19-integration openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.19-security openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.18-ci-index openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.18-ci-job openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.18-images openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.18-integration openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.18-security openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.12-ci-index openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.12-ci-job openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.12-images openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.12-integration openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.22-ci-index openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed
pull-ci-openshift-kni-cluster-group-upgrades-operator-release-4.22-ci-job openshift-kni/cluster-group-upgrades-operator presubmit Ci-operator config changed

A total of 43 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2026

@fontivan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants