NO-JIRA: upkeep: streamline build images and promotion#79058
NO-JIRA: upkeep: streamline build images and promotion#79058eggfoobar wants to merge 2 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eggfoobar: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughReplaces inline Dockerfile literals with Dockerfile path references for two CI images, expands image promotion to include those images, simplifies markdownlint test job to use the new image, and removes the install_prerequisites() function and its call from the microshift CI doctor script. ChangesContainer build and test wiring
Microshift CI doctor script cleanup
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yaml`:
- Around line 17-30: The CI config references three missing Containerfiles
(dockerfile_path: images/Containerfile.tooling,
images/Containerfile.markdownlint, images/Containerfile.ci) which will break
ci-operator; fix it by either adding the missing Containerfile files into an
images/ directory at those exact paths or updating the dockerfile_path values to
point to the correct existing Containerfile locations, and ensure any related
inputs/targets (to: gh-token, to: markdownlint-cli2, to: edge-tooling-ai-helpers
and the inputs.gh-token paths) are consistent with the new locations so the
builds can find the Dockerfiles.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a67db28f-2e6e-4721-a1b5-010e22e9effc
⛔ Files ignored due to path filters (2)
ci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-postsubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/openshift-eng/edge-tooling/openshift-eng-edge-tooling-main.yamlci-operator/step-registry/openshift/edge-tooling/microshift-ci/doctor/openshift-edge-tooling-microshift-ci-doctor-ref.yaml
|
/pj-rehearse |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
updated to build from repo container files updated to promote the tooling to be used by other periodics added linter image instead of test build image Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
upkeep-streamline-edge-tooling-images
branch
from
f06ff71 to
53cb8cc
Compare
|
/pj-rehearse |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eggfoobar
force-pushed
the
upkeep-streamline-edge-tooling-images
branch
from
36e44ab to
c18f660
Compare
|
/pj-rehearse |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
upkeep-streamline-edge-tooling-images
branch
from
c18f660 to
1d97188
Compare
|
/pj-rehearse |
|
@eggfoobar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@eggfoobar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
updated to build from repo container files
updated to promote the tooling to be used by other periodics
added linter image instead of test build image
Summary
Updates CI configuration for the openshift-eng/edge-tooling repository to build and promote reusable tooling images from Containerfiles, simplify tests to run inside those images, and remove in-script prerequisite installation in the microshift-ci doctor step so the execution image must provide required tooling.
What changed (practical impact)
Files/areas affected
These changes centralize Containerfile maintenance, make tooling images reusable across CI jobs, and reduce runtime setup by depending on more fully provisioned execution images.