Skip to content

installer: set BUILD_VERSION arg#79061

Open
patrickdillon wants to merge 1 commit intoopenshift:mainfrom
patrickdillon:installer_build_version
Open

installer: set BUILD_VERSION arg#79061
patrickdillon wants to merge 1 commit intoopenshift:mainfrom
patrickdillon:installer_build_version

Conversation

@patrickdillon
Copy link
Copy Markdown
Contributor

@patrickdillon patrickdillon commented May 8, 2026

Sets BUILD_VERSION similar to nightlies. We will use this to distinguish between 5.0+ behavior and 4.23.
set a build version to be able

Summary

This PR adds a BUILD_VERSION build argument to the OpenShift installer's CI configuration. The BUILD_VERSION is set to "5.0.0" and will be passed to all Docker image builds in the installer's CI pipeline.

What Changed

The change modifies ci-operator/config/openshift/installer/openshift-installer-main.yaml to add a build_args section in the image build configuration:

images:
  build_args:
  - name: BUILD_VERSION
    value: "5.0.0"
  items:
    - dockerfile_path: images/installer/Dockerfile.ci
      to: installer
    - ...

Why It Matters

The BUILD_VERSION environment variable will be available during the Docker image builds for all installer container images (installer, libvirt-installer, upi-installer, baremetal-installer, etc.). This allows the build process and the resulting binaries to:

  • Distinguish between 5.0+ behavior and 4.23 behavior
  • Apply version-specific logic or features during builds
  • Mirror the approach already used in nightly builds

This is foundational infrastructure change that enables version-aware behavior in the OpenShift installer CI pipeline.

Sets BUILD_VERSION similar to nightlies. We will use this to distinguish
between 5.0+ behavior and 4.23.
set a build version to be able
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 987ce1c2-2850-4d95-9c59-ea3e3e1e42e8

📥 Commits

Reviewing files that changed from the base of the PR and between 9705dea and f60d468.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/installer/openshift-installer-main.yaml

Walkthrough

The pull request adds a build argument BUILD_VERSION with value "5.0.0" to the OpenShift installer CI configuration. This is a single-file configuration update affecting the image build stage of the ci-operator definition.

Changes

CI Configuration Update

Layer / File(s) Summary
Build Configuration
ci-operator/config/openshift/installer/openshift-installer-main.yaml
Adds BUILD_VERSION: "5.0.0" to images.build_args for the image build stage (lines 66–68).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'installer: set BUILD_VERSION arg' directly and clearly describes the main change: adding a BUILD_VERSION build argument to the OpenShift installer CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR only modifies CI configuration files, not Ginkgo tests. The check about stable/deterministic test names is not applicable.
Test Structure And Quality ✅ Passed Custom check is not applicable. PR modifies only a CI/CD YAML config file (adds BUILD_VERSION argument), not Ginkgo test code. No test files or patterns present.
Microshift Test Compatibility ✅ Passed This PR only modifies CI configuration to add a BUILD_VERSION build argument. No Ginkgo e2e tests are added or modified, so the MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies a CI configuration YAML file to add a BUILD_VERSION build argument. No new Ginkgo e2e tests are added, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The PR modifies CI build configuration, not deployment manifests, operator code, or controllers. Topology-aware scheduling check does not apply.
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI configuration. The OTE Stdout Contract check applies to executable code (main(), init(), TestMain(), etc.), which are not present here.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI config to set BUILD_VERSION. No Ginkgo e2e tests are added, making the IPv6 compatibility check not applicable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@patrickdillon
Copy link
Copy Markdown
Contributor Author

/pj-rehearse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant