installer: set BUILD_VERSION arg#79061
Open
patrickdillon wants to merge 1 commit intoopenshift:mainfrom
Open
Conversation
Sets BUILD_VERSION similar to nightlies. We will use this to distinguish between 5.0+ behavior and 4.23. set a build version to be able
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughThe pull request adds a build argument ChangesCI Configuration Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
/pj-rehearse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets BUILD_VERSION similar to nightlies. We will use this to distinguish between 5.0+ behavior and 4.23.
set a build version to be able
Summary
This PR adds a
BUILD_VERSIONbuild argument to the OpenShift installer's CI configuration. TheBUILD_VERSIONis set to"5.0.0"and will be passed to all Docker image builds in the installer's CI pipeline.What Changed
The change modifies
ci-operator/config/openshift/installer/openshift-installer-main.yamlto add abuild_argssection in the image build configuration:Why It Matters
The
BUILD_VERSIONenvironment variable will be available during the Docker image builds for all installer container images (installer, libvirt-installer, upi-installer, baremetal-installer, etc.). This allows the build process and the resulting binaries to:This is foundational infrastructure change that enables version-aware behavior in the OpenShift installer CI pipeline.