Adding ARO post submit jobs#79062
Conversation
WalkthroughAzure ARO-RP CI configuration is updated with a new e2e test configuration file and location parameter adjustments. The ChangesAzure ARO-RP E2E Configuration and Location Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yaml`:
- Line 26: Several postsubmit job entries include the literal filter
"run_if_changed: ^$" which matches nothing and prevents those postsubmit jobs
from ever running; remove the "run_if_changed: ^$" lines from each postsubmit
job block (the blocks that define postsubmit jobs for this repo) so the jobs run
on every matching push, or replace the value with a meaningful regex like
"\.go$" if you only want them to trigger on specific file types; search for
occurrences of the exact string "run_if_changed: ^$" and delete or update them
in the postsubmit job definitions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1120561c-27d0-4d42-895d-41aab3195695
⛔ Files ignored due to path filters (1)
ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-postsubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yamlci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yamlci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__periodic.yaml
|
/lgtm |
|
/pj-rehearse branch-ci-Azure-ARO-RP-master-e2e-prod-e2e-parallel-csp |
Adding ARO post submit jobs. I believe this is the more correct type of test to invoke post-deployment. Also pointing the int and stg jobs to the correct environment by default because it's been bothering me.
ARO Post-Submit E2E Jobs
This PR adds CI infrastructure for Azure Red Hat OpenShift (ARO) by introducing postsubmit end-to-end test jobs.
What's Being Added
The PR creates a new CI configuration for the ARO-RP (Azure Red Hat OpenShift - Resource Provider) repository master branch, establishing post-submit testing across three deployment environments:
eastusAzure regionwestus2Azure regionuksouthAzure regionJob Structure
Two test variants are configured to run after merges:
Each variant runs across all three environments (6 postsubmit jobs total), using the
aro-classic-e2eworkflow to execute end-to-end tests with OCP 4.22. The tests include resource limits and requests (100mCPU /200Mimemory request,4Gimemory limit) to control execution footprint.The configuration also defines corresponding periodic job variants (scheduled with cron
0 0 1 1 *) for the same test combinations.Files Modified
ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yaml- New postsubmit test configuration (82 lines)ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__periodic.yaml- New periodic test configuration (82 lines)ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yaml- Main ARO-RP CI configuration (113 lines)ci-operator/jobs/Azure/ARO-RP/(postsubmits, periodics, presubmits)