Skip to content

Adding ARO post submit jobs#79062

Open
rachelvweber wants to merge 1 commit intoopenshift:mainfrom
rachelvweber:rawo/addingAroPostsubmitJobs
Open

Adding ARO post submit jobs#79062
rachelvweber wants to merge 1 commit intoopenshift:mainfrom
rachelvweber:rawo/addingAroPostsubmitJobs

Conversation

@rachelvweber
Copy link
Copy Markdown
Contributor

@rachelvweber rachelvweber commented May 8, 2026

Adding ARO post submit jobs. I believe this is the more correct type of test to invoke post-deployment. Also pointing the int and stg jobs to the correct environment by default because it's been bothering me.

ARO Post-Submit E2E Jobs

This PR adds CI infrastructure for Azure Red Hat OpenShift (ARO) by introducing postsubmit end-to-end test jobs.

What's Being Added

The PR creates a new CI configuration for the ARO-RP (Azure Red Hat OpenShift - Resource Provider) repository master branch, establishing post-submit testing across three deployment environments:

  • Integration environment - Uses eastus Azure region
  • Staging environment - Uses westus2 Azure region
  • Production environment - Uses uksouth Azure region

Job Structure

Two test variants are configured to run after merges:

  • miwi test variant
  • csp test variant

Each variant runs across all three environments (6 postsubmit jobs total), using the aro-classic-e2e workflow to execute end-to-end tests with OCP 4.22. The tests include resource limits and requests (100m CPU / 200Mi memory request, 4Gi memory limit) to control execution footprint.

The configuration also defines corresponding periodic job variants (scheduled with cron 0 0 1 1 *) for the same test combinations.

Files Modified

  • ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yaml - New postsubmit test configuration (82 lines)
  • ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__periodic.yaml - New periodic test configuration (82 lines)
  • ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yaml - Main ARO-RP CI configuration (113 lines)
  • Generated Prow job YAML files in ci-operator/jobs/Azure/ARO-RP/ (postsubmits, periodics, presubmits)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Walkthrough

Azure ARO-RP CI configuration is updated with a new e2e test configuration file and location parameter adjustments. The LOCATION environment variable is changed from uksouth to eastus for integration test jobs and from uksouth to westus2 for stage test jobs across both master and periodic workflows.

Changes

Azure ARO-RP E2E Configuration and Location Updates

Layer / File(s) Summary
E2E Test Configuration Foundation
ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yaml
New e2e CI configuration file defining base image mappings (aro-classic-ci-images), build root, OCP 4.22 release integration, resource defaults, and six postsubmit e2e test job definitions for miwi and csp types across integration/stage/prod cluster profiles.
Location Parameter Updates
ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yaml, ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__periodic.yaml
LOCATION environment variable updated for parallel e2e test jobs: integration-e2e-parallel-miwi and integration-e2e-parallel-csp change from uksouth to eastus; stage-e2e-parallel-miwi and stage-e2e-parallel-csp change from uksouth to westus2.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Adding ARO post submit jobs' directly aligns with the primary change: introducing new post-submit e2e test configuration for ARO, as evidenced by the new e2e.yaml file and LOCATION updates across multiple test jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains only CI/CD YAML configuration files with no Ginkgo test code. Check for stable test names is not applicable here.
Test Structure And Quality ✅ Passed PR contains only YAML CI/CD configuration files, no Ginkgo test code. The custom check for Ginkgo test quality is not applicable.
Microshift Test Compatibility ✅ Passed This PR only modifies CI configuration files (YAML). No new Ginkgo e2e test code is added. The custom check requires analyzing test code for MicroShift compatibility, which is not applicable here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR contains only YAML CI configuration files, not Ginkgo e2e test code. The custom check applies only to new Ginkgo test definitions, which are absent here.
Topology-Aware Scheduling Compatibility ✅ Passed Modifies only CI test configuration files, not deployment manifests or operator code. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check is not applicable to this PR. All changes are CI operator YAML configuration files with no executable source code that could violate stdout communication contracts.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR adds CI configuration files (YAML) only, not new Ginkgo test code. The check applies to new Go test files with It(), Describe(), etc., which are absent.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yaml`:
- Line 26: Several postsubmit job entries include the literal filter
"run_if_changed: ^$" which matches nothing and prevents those postsubmit jobs
from ever running; remove the "run_if_changed: ^$" lines from each postsubmit
job block (the blocks that define postsubmit jobs for this repo) so the jobs run
on every matching push, or replace the value with a meaningful regex like
"\.go$" if you only want them to trigger on specific file types; search for
occurrences of the exact string "run_if_changed: ^$" and delete or update them
in the postsubmit job definitions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1120561c-27d0-4d42-895d-41aab3195695

📥 Commits

Reviewing files that changed from the base of the PR and between 9705dea and c3939f9.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/Azure/ARO-RP/Azure-ARO-RP-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master.yaml
  • ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yaml
  • ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__periodic.yaml

Comment thread ci-operator/config/Azure/ARO-RP/Azure-ARO-RP-master__e2e.yaml
@stevekuznetsov
Copy link
Copy Markdown
Contributor

/lgtm
/approve
/ok-to-test

@rachelvweber
Copy link
Copy Markdown
Contributor Author

/pj-rehearse branch-ci-Azure-ARO-RP-master-e2e-prod-e2e-parallel-csp

@rachelvweber rachelvweber marked this pull request as draft May 8, 2026 22:02
@rachelvweber rachelvweber marked this pull request as ready for review May 8, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants