Check if hotkey is registered in any network only if netuid is not provided.#2487
Open
evgeny-s wants to merge 17 commits intoopentensor:devnet-readyfrom
Open
Check if hotkey is registered in any network only if netuid is not provided.#2487evgeny-s wants to merge 17 commits intoopentensor:devnet-readyfrom
evgeny-s wants to merge 17 commits intoopentensor:devnet-readyfrom
Conversation
…st: `test_swap_hotkey_registered_on_other_subnet`
# Conflicts: # pallets/subtensor/src/tests/swap_hotkey_with_subnet.rs # runtime/src/lib.rs
open-junius
reviewed
Mar 6, 2026
| !Self::is_hotkey_registered_on_any_network(new_hotkey), | ||
| Error::<T>::HotKeyAlreadyRegisteredInSubNet | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
It is better to add is_hotkey_registered_on_specific_network check if netuid == Some(netuid).
Author
There was a problem hiding this comment.
Added additional check, like you suggested here: 893bfb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the inability to revert a hotkey swap by disabling
is_hotkey_registered_on_any_networkfor cases where netuid is provided.More changes:
HotkeySwapOnSubnetIntervalfrom 5 days to 1 day.Parent keys,Child keys,Pending child keys,Auto stake destination,Subnet ownership,Dividend records,Voting Power,Root Reclaimable.test_swap_hotkey_registered_on_other_subnet, since it tests the condition that is no longer valid.Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.