-
Notifications
You must be signed in to change notification settings - Fork 288
Check if hotkey is registered in any network only if netuid is not provided. #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
evgeny-s
wants to merge
17
commits into
opentensor:devnet-ready
Choose a base branch
from
evgeny-s:evgeny-revert-swap-key
base: devnet-ready
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+703
−26
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
651bf4c
- Add a possibility to revert hotkey back after the swap
evgeny-s 6c16a18
- Updated HotkeySwapOnSubnetInterval to 1 day.
evgeny-s 250a881
- Added test `test_revert_hotkey_swap_stake_is_not_lost` + removed te…
evgeny-s ccde975
- Added stake to hk1 after swap
evgeny-s 8e63fa0
- Moved tests to the correct file
evgeny-s d29c9e6
- Added test to check revert hotkey for parent keys and child keys
evgeny-s 72ef608
- tests for: ParentKeys + Uid + AutoStakeDestination + SubnetOwnership
evgeny-s 7bd2ca1
- tests for: Dividends
evgeny-s df3f2e8
- tests for: VotingPower
evgeny-s 4be737a
- tests for: RootClaimed + RootClaimable
evgeny-s b04f7d4
Merge branch 'devnet-ready' into evgeny-revert-swap-key
evgeny-s d3cb527
commit Cargo.lock
evgeny-s 1cc0644
commit Cargo.lock
evgeny-s a715453
cargo clippy
evgeny-s 5e85bb3
cargo fmt
evgeny-s 893bfb0
Add check for `is_hotkey_registered_on_specific_network` when `netuid…
evgeny-s c62a01d
- Fix for clippy
evgeny-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to add is_hotkey_registered_on_specific_network check if netuid == Some(netuid).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added additional check, like you suggested here: 893bfb0