Skip to content

Conversation

@jeremias-jordan
Copy link

Added setDomesticHotWaterSchedule command for Heating Devices. Tested with V200KW1.

@jeremias-jordan
Copy link
Author

It's been a while and i'd really like to see this command available. Any news on this PR?

@CFenner
Copy link
Member

CFenner commented Jan 19, 2025

Thanks for the PR, could you add types to the function and parameters. Also tests would be nice.

@lackas
Copy link
Contributor

lackas commented Feb 3, 2026

Here's what CFenner is asking for:

Type annotations:

@handleAPICommandErrors
def setDomesticHotWaterSchedule(self, schedule: dict):
    return self.service.setProperty("heating.dhw.schedule", "setSchedule",
                                    {'newSchedule': schedule})

Test (e.g., in test_Vitocal200.py which has the setSchedule command):

def test_getDomesticHotWaterScheduleModes(self):
    expected_modes = ['on']  # check your test data for actual modes
    self.assertSetEqual(
        set(self.device.getDomesticHotWaterScheduleModes()), expected_modes)

You might also want to add getDomesticHotWaterScheduleModes() to retrieve available modes, following the pattern of getDomesticHotWaterCirculationScheduleModes().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants