Feature/Kleinanzeigen addresses#289
Feature/Kleinanzeigen addresses#289orangecoding merged 4 commits intoorangecoding:feature/kleinanzeigen_newfrom
Conversation
|
Also I've renamend Ebay Kleinanzeigen to just Kleinanzeigen |
orangecoding
left a comment
orangecoding
left a comment
There was a problem hiding this comment.
Hey. Thanks for this. I've added some comments.
PLease also add some documentation.
| </div> | ||
| </SegmentPart> | ||
|
|
||
| <SegmentPart |
There was a problem hiding this comment.
Why do you put this both in the General Settings AND the user Settings? I'd vote for just putting it into the UserSettings
There was a problem hiding this comment.
I've just thought about it again. Wouldn't it make sense to make the additional details job based and put it in the job settings?
For some jobs, the exact location might be more important than the others.
Like finding real estate in rural areas vs. cities.
There was a problem hiding this comment.
Yeah, I do agree and I like this thinking.
We would need to adjust the logic to make it more generic plus we must make it 1 setting only..
Would you enable it by default or disable it as a default setting?
There was a problem hiding this comment.
I have not encountered any rate limiting on ImmoScout or Kleinanzeigen thus far when running jobs.
So if it were up to me I would leave on by default because I find the additional details to be extremely valuable. ^^
There was a problem hiding this comment.
How do you want to go about this. Do you want me to merge your pr, and then build up on top of it?
Would that be ok with you?
There was a problem hiding this comment.
If you can spare the time sure!
There was a problem hiding this comment.
Yeah. I just want to make sure it's ok with you as this is your source/idea.
Of course I'll attribute your work as such :)
|
@claude review |
orangecoding
merged commit c9cc39a
into
orangecoding:feature/kleinanzeigen_new
2 participants
It was bugging me that Kleinanzeigen listings only provided the postal code and not the full address.
As a result, they didn't show up on the map correctly.
This PR provides a toggle similar to Immoscout Details that allows the scraping of individual listings so as to provide a full address and description.