-
-
Notifications
You must be signed in to change notification settings - Fork 139
Feature/Kleinanzeigen addresses #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4bf6937
dde2be0
575420b
ec8fccd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -73,6 +73,7 @@ const GeneralSettings = function GeneralSettings() { | |
| // User settings state | ||
| const homeAddress = useSelector((state) => state.userSettings.settings.home_address); | ||
| const immoscoutDetails = useSelector((state) => state.userSettings.settings.immoscout_details); | ||
| const kleinanzeigenDetails = useSelector((state) => state.userSettings.settings.kleinanzeigen_details); | ||
| const [address, setAddress] = useState(homeAddress?.address || ''); | ||
| const [coords, setCoords] = useState(homeAddress?.coords || null); | ||
| const saving = useIsLoading(actions.userSettings.setHomeAddress); | ||
|
|
@@ -465,6 +466,32 @@ const GeneralSettings = function GeneralSettings() { | |
| </div> | ||
| </SegmentPart> | ||
|
|
||
| <SegmentPart | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you put this both in the General Settings AND the user Settings? I'd vote for just putting it into the UserSettings
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've just thought about it again. Wouldn't it make sense to make the additional details job based and put it in the job settings?
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I do agree and I like this thinking. We would need to adjust the logic to make it more generic plus we must make it 1 setting only.. Would you enable it by default or disable it as a default setting?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have not encountered any rate limiting on ImmoScout or Kleinanzeigen thus far when running jobs.
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How do you want to go about this. Do you want me to merge your pr, and then build up on top of it?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you can spare the time sure!
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah. I just want to make sure it's ok with you as this is your source/idea. |
||
| name="Kleinanzeigen Details" | ||
| helpText="Fetch the individual listing page for each Kleinanzeigen result to extract a more detailed address and description. Makes an extra request per listing." | ||
| > | ||
| <Banner | ||
| type="warning" | ||
| description="Enabling this significantly increases requests to Kleinanzeigen, raising the chance of rate limiting or blocking. Use at your own risk." | ||
| closeIcon={null} | ||
| style={{ marginBottom: 12 }} | ||
| /> | ||
| <div style={{ display: 'flex', alignItems: 'center', gap: 10 }}> | ||
| <Switch | ||
| checked={!!kleinanzeigenDetails} | ||
| onChange={async (checked) => { | ||
| try { | ||
| await actions.userSettings.setKleinanzeigenDetails(checked); | ||
| Toast.success('Kleinanzeigen details setting updated.'); | ||
| } catch { | ||
| Toast.error('Failed to update setting.'); | ||
| } | ||
| }} | ||
| /> | ||
| <Text>Fetch detailed Kleinanzeigen listings</Text> | ||
| </div> | ||
| </SegmentPart> | ||
|
|
||
| <div className="generalSettings__save-row"> | ||
| <Button | ||
| icon={<IconSave />} | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.