Conversation
…edIframe support Add a callback mechanism to detect when a live preview iframe is embedded within Phoenix vs popped out. The callback is guaranteed to fire in embedded iframes but not in non-embedded frames. Also pass isPhoenixEmbeddedIframe in the WHO_AM_I_RESPONSE handshake.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
browser windows
API
Quirks
How hot-corners uses it
Creates the hot corner optimistically, then registers onPhoenixEmbeddedInfoAvailable — if it confirms embedded, removes the hot corner. This avoids depending on the callback for the non-embedded case.