Skip to content

Fix: framework to detect embedded live preview in phoenix code #2756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 4 commits into from
Mar 20, 2026
+46 −12

fix: wrong ver name for isPhoenixEmbeddedIframe in md live preview

70dbba3
Select commit
Loading
Failed to load commit list.
Merged

Fix: framework to detect embedded live preview in phoenix code #2756

fix: wrong ver name for isPhoenixEmbeddedIframe in md live preview
70dbba3
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 20, 2026 in 34s

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 460 in src/LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ0KtT1eg2wgUSNrNQT_&open=AZ0KtT1eg2wgUSNrNQT_&pullRequest=2756

Check warning on line 520 in src/LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected a `for-of` loop instead of a `for` loop with this simple iteration. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ0KtT1eg2wgUSNrNQUC&open=AZ0KtT1eg2wgUSNrNQUC&pullRequest=2756

Check warning on line 517 in src/LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ0KtT1eg2wgUSNrNQUB&open=AZ0KtT1eg2wgUSNrNQUB&pullRequest=2756

Check warning on line 450 in src/LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ0KtT1eg2wgUSNrNQT8&open=AZ0KtT1eg2wgUSNrNQT8&pullRequest=2756

Check warning on line 461 in src/LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ0KtT1eg2wgUSNrNQUA&open=AZ0KtT1eg2wgUSNrNQUA&pullRequest=2756

Check warning on line 459 in src/LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ0KtT1eg2wgUSNrNQT9&open=AZ0KtT1eg2wgUSNrNQT9&pullRequest=2756

Check warning on line 460 in src/LiveDevelopment/BrowserScripts/LivePreviewTransportRemote.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix&issues=AZ0KtT1eg2wgUSNrNQT-&open=AZ0KtT1eg2wgUSNrNQT-&pullRequest=2756
View more details on SonarQubeCloud