-
Notifications
You must be signed in to change notification settings - Fork 415
tiflash-proxy-next-gen: bump for CMEK encrypted data #10646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
📝 WalkthroughWalkthroughThe pull request updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8074e2b to
8ba91f7
Compare
79809aa to
d9d4d9c
Compare
Bump contrib/tiflash-proxy-next-gen to c013b172a259ccf11f23303097cd2b940f13e192 so that it can recognize the encrypted raft logs and SST files by next-gen CMEK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@contrib/tiflash-proxy-next-gen`:
- Line 1: Add automated integration tests to cover CMEK-encrypted data
compatibility: implement tests named like TestTiFlashCMEK_RaftLogs and
TestTiFlashCMEK_SSTFiles to bring up a TiKV/TiFlash test cluster with CMEK
enabled and verify the TiFlash proxy (the proxy component under
contrib/tiflash-proxy-next-gen) can read encrypted raft logs and SST files, and
add TestTiFlash_NoCMEK_Backcompat to ensure non-CMEK deployments still work.
Hook these into the existing integration test harness (e.g., the package tests
or integration_test suite used by contrib/tiflash-proxy-next-gen), reuse helpers
that start a TiKV/TiFlash cluster and inject CMEK keys, and assert proxy startup
and successful reads of raft log entries and SST content; fail the test if the
proxy crashes or returns decryption errors. Ensure tests clean up keys/state and
can be toggled/skipped if CMEK environment (KMS) is unavailable.
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-nextgen-20251011 |
|
@JaySon-Huang: once the present PR merges, I will cherry-pick it on top of release-nextgen-20251011 in the new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
@JaySon-Huang: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #10222
Problem Summary:
When next-gen CMEK is enabled, raft logs and SST files can be encrypted by TiFlash proxy; the currently pinned tiflash-proxy-next-gen version can't recognize/read the encrypted data formats.
What is changed and how it works?
Check List
Tests
InvalidChecksumorencryption_key is not foundwithout this commit.Side effects
Documentation
Release note
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.