Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #10646

What problem does this PR solve?

Issue Number: ref #10222

Problem Summary:
When next-gen CMEK is enabled, raft logs and SST files can be encrypted by TiFlash proxy; the currently pinned tiflash-proxy-next-gen version can't recognize/read the encrypted data formats.

What is changed and how it works?

Bump submodule contrib/tiflash-proxy-next-gen to c013b172a259ccf11f23303097cd2b940f13e192 to pick up next-gen CMEK compatibility changes.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • Verified that when CMEK is enabled and TiFlash is enabled, TiFlash proxy would crash due to InvalidChecksum or encryption_key is not found without this commit.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Chores
    • Updated internal submodule reference to maintain compatibility.

✏️ Tip: You can customize this high-level summary in your review settings.

Bump contrib/tiflash-proxy-next-gen to c013b172a259ccf11f23303097cd2b940f13e192 so that it can recognize the encrypted raft logs and SST files by next-gen CMEK.
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011 labels Jan 22, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • release-8.5
  • release-7.5
  • release-8.1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 22, 2026
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 22, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 22, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-22 09:08:54.857625164 +0000 UTC m=+657762.471582020: ☑️ agreed by JaySon-Huang.
  • 2026-01-22 09:10:47.788524404 +0000 UTC m=+657875.402481250: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 23, 2026
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2026

@kolafish: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang, kolafish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 4fda605 into pingcap:release-nextgen-20251011 Jan 23, 2026
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-10646-to-release-nextgen-20251011 branch January 23, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants