Don't truncate commands + show running commands#1775
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR changes runtime UI behavior by showing running commands and removing command truncation. An unresolved high-severity review comment identifies a collapse key mismatch bug that would leave phantom 'Running command' entries visible after completion. You can customize Macroscope's approvability policy. Learn more. |
b042087 to
941b722
Compare
941b722 to
74d4e79
Compare
74d4e79 to
7667c93
Compare
7667c93 to
0437846
Compare
0437846 to
979f8c0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 979f8c0. Configure here.
| : lifecycle === "item.completed" | ||
| ? "completed" | ||
| : undefined; | ||
| const title = itemTitle(itemType, lifecycle === "item.started"); |
There was a problem hiding this comment.
Updated commands prematurely labeled "Ran command" while still running
Medium Severity
itemTitle receives started = true only when lifecycle === "item.started". For item.updated events — which fire while a command is still executing — started is false, so the title becomes "Ran command". When merged with the tool.started entry, the label prematurely changes from "Running command" to "Ran command", undermining the PR's core feature of indicating running state.
Reviewed by Cursor Bugbot for commit 979f8c0. Configure here.
9d317d4 to
0258762
Compare
- Stop truncating `detail` when ingesting provider runtime tool events
- carry item IDs and payload data through server ingestion - collapse tool lifecycle rows by stable item IDs - keep command start rows visible with clearer labels
0258762 to
1b0d1c1
Compare


What Changed
truncateDetailcall for tool calls send by the agent (the output is still truncated via css ellipsis in the UI, but can be viewed by hovering)Why
UI Changes
https://www.youtube.com/watch?v=SJUpSWBkfUk
PS: Also works with the latest changes to not show the shell wrapper, this PR is unaffected by that.

Checklist
Note
Medium Risk
Medium risk because it changes server→web event payload shape (
itemId) and rewrites work-log collapsing logic, which could affect timeline ordering/merging for tool lifecycle entries.Overview
Work log entries now include
tool.startedso users can see in-progress tool/command execution (with lifecycle-aware titles like “Running command” vs “Ran command”).Server ingestion and provider mapping propagate
itemIdinto tool lifecycle activity payloads and stop truncatingdetailfortool.started/tool.completedevents, keeping full command/detail text available to the UI.Web collapsing logic is reworked to merge
tool.started/tool.updated/tool.completedinto a single row using a stablecollapseKey(preferringtoolCallId, thenitemId, then a normalized fallback), even when lifecycle events are non-adjacent; merged rows retain the originalid/createdAtfrom the first event.Reviewed by Cursor Bugbot for commit 1b0d1c1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Show running commands in work log and stop truncating command details
itemTitlein CodexAdapter.ts.tool.startedevents are no longer filtered out of the work log andtool.detailis forwarded without truncation in ProviderRuntimeIngestion.ts.tool.started,tool.updated, andtool.completedentries into a single row using a stablecollapseKey(preferringtoolCallIdoritemId), even when entries are non-adjacent.idandcreatedAtfrom the first entry rather than the latest event's values.Macroscope summarized 1b0d1c1.