-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Don't truncate commands + show running commands #1775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -235,7 +235,7 @@ function toCanonicalItemType(raw: string | undefined | null): CanonicalItemType | |
| return "unknown"; | ||
| } | ||
|
|
||
| function itemTitle(itemType: CanonicalItemType): string | undefined { | ||
| function itemTitle(itemType: CanonicalItemType, started = false): string | undefined { | ||
| switch (itemType) { | ||
| case "assistant_message": | ||
| return "Assistant message"; | ||
|
|
@@ -246,7 +246,7 @@ function itemTitle(itemType: CanonicalItemType): string | undefined { | |
| case "plan": | ||
| return "Plan"; | ||
| case "command_execution": | ||
| return "Ran command"; | ||
| return started ? "Running command" : "Ran command"; | ||
| case "file_change": | ||
| return "File change"; | ||
| case "mcp_tool_call": | ||
|
|
@@ -469,14 +469,15 @@ function mapItemLifecycle( | |
| : lifecycle === "item.completed" | ||
| ? "completed" | ||
| : undefined; | ||
| const title = itemTitle(itemType, lifecycle === "item.started"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated commands prematurely labeled "Ran command" while still runningMedium Severity
Reviewed by Cursor Bugbot for commit 979f8c0. Configure here. |
||
|
|
||
| return { | ||
| ...runtimeEventBase(event, canonicalThreadId), | ||
| type: lifecycle, | ||
| payload: { | ||
| itemType, | ||
| ...(status ? { status } : {}), | ||
| ...(itemTitle(itemType) ? { title: itemTitle(itemType) } : {}), | ||
| ...(title ? { title } : {}), | ||
| ...(detail ? { detail } : {}), | ||
| ...(event.payload !== undefined ? { data: event.payload } : {}), | ||
| }, | ||
|
|
||


Uh oh!
There was an error while loading. Please reload this page.