Skip to content

feat(git): support custom commit flags for app-run commits#977

Open
0xnim wants to merge 2 commits intopingdotgg:mainfrom
0xnim:main
Open

feat(git): support custom commit flags for app-run commits#977
0xnim wants to merge 2 commits intopingdotgg:mainfrom
0xnim:main

Conversation

@0xnim
Copy link

@0xnim 0xnim commented Mar 12, 2026

Related to #274.

What Changed

  • Added support for passing extra git commit flags
  • Added a Settings field for app run git commit flags, so users can configure flags like --no-gpg-sign

Why

T3 Code runs git commit non-interactively. On a machine with global commit.gpgsign=true, commits can fail because GPG prompts for a pass on /dev/tty, which does not exist in this case.

This PR does NOT add interactive GPG/password support. Instead its a small workaround fix, users can configure extra commit flags for app run commits, which makes setups like --no-gpg-sign possible without changing their global git config

UI Changes

Adds a new Settings field under Git for extra git commit flags

Before After
Screenshot 2026-03-12 at 3 27 23 AM Screenshot 2026-03-12 at 3 27 06 AM

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Add custom git commit flags support to app-run commits

  • Adds a gitCommitFlags string field to AppSettingsSchema and a commitFlags field to the GitRunStackedActionInput API contract, allowing users to pass arbitrary flags to git commit.
  • Adds a settings UI in _chat.settings.tsx where users can configure and reset commit flags.
  • The flags string is tokenized via a new tokenizeCommitFlags helper in GitManager.ts and injected into the git CLI args in GitCore.commit.
  • GitActionsControl reads settings.gitCommitFlags and forwards it through the mutation chain to the backend when non-empty.

Macroscope summarized 55e0309.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e716cdbc-72f3-4b7c-9d69-acdb04079136

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.

OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 12, 2026
@0xnim
Copy link
Author

0xnim commented Mar 12, 2026

The worker errors seem to be pre existing

@juliusmarminge
Copy link
Member

juliusmarminge commented Mar 12, 2026

The worker errors seem to be pre existing

it's flaky right now but it keeps failing on this branch...

also can you resolve conflicts pls. i am unable to push since you PRd from main:
CleanShot 2026-03-12 at 12 08 41@2x

@juliusmarminge juliusmarminge added the accepted feature request accepted label Mar 12, 2026
@0xnim
Copy link
Author

0xnim commented Mar 12, 2026

Apologies, I never realized that was the reason you don't pr from main. I'll do it now.

# Conflicts:
#	apps/server/src/git/Layers/GitCore.test.ts
#	apps/web/src/components/GitActionsControl.tsx
@github-actions github-actions bot added the size:M 30-99 changed lines (additions + deletions). label Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted feature request accepted size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants