Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/git/Layers/GitCore.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const makeIsolatedGitCore = (gitService: GitServiceShape) =>
status: (input) => core.status(input),
statusDetails: (cwd) => core.statusDetails(cwd),
prepareCommitContext: (cwd, filePaths?) => core.prepareCommitContext(cwd, filePaths),
commit: (cwd, subject, body) => core.commit(cwd, subject, body),
commit: (cwd, subject, body, extraArgs?) => core.commit(cwd, subject, body, extraArgs),
pushCurrentBranch: (cwd, fallbackBranch) => core.pushCurrentBranch(cwd, fallbackBranch),
pullCurrentBranch: (cwd) => core.pullCurrentBranch(cwd),
readRangeContext: (cwd, baseBranch) => core.readRangeContext(cwd, baseBranch),
Expand Down
4 changes: 2 additions & 2 deletions apps/server/src/git/Layers/GitCore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -804,9 +804,9 @@ const makeGitCore = Effect.gen(function* () {
};
});

const commit: GitCoreShape["commit"] = (cwd, subject, body) =>
const commit: GitCoreShape["commit"] = (cwd, subject, body, extraArgs = []) =>
Effect.gen(function* () {
const args = ["commit", "-m", subject];
const args = ["commit", ...extraArgs, "-m", subject];
const trimmedBody = body.trim();
if (trimmedBody.length > 0) {
args.push("-m", trimmedBody);
Expand Down
16 changes: 15 additions & 1 deletion apps/server/src/git/Layers/GitManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,13 @@ interface CommitAndBranchSuggestion {
commitMessage: string;
}

function tokenizeCommitFlags(rawFlags?: string): string[] {
return (rawFlags ?? "")
.trim()
.split(/\s+/g)
.filter((value) => value.length > 0);
}

function formatCommitMessage(subject: string, body: string): string {
const trimmedBody = body.trim();
if (trimmedBody.length === 0) {
Expand Down Expand Up @@ -680,6 +687,7 @@ export const makeGitManager = Effect.gen(function* () {
cwd: string,
branch: string | null,
commitMessage?: string,
commitFlags?: string,
preResolvedSuggestion?: CommitAndBranchSuggestion,
filePaths?: readonly string[],
) =>
Expand All @@ -696,7 +704,12 @@ export const makeGitManager = Effect.gen(function* () {
return { status: "skipped_no_changes" as const };
}

const { commitSha } = yield* gitCore.commit(cwd, suggestion.subject, suggestion.body);
const { commitSha } = yield* gitCore.commit(
cwd,
suggestion.subject,
suggestion.body,
tokenizeCommitFlags(commitFlags),
);
return {
status: "created" as const,
commitSha,
Expand Down Expand Up @@ -1042,6 +1055,7 @@ export const makeGitManager = Effect.gen(function* () {
input.cwd,
currentBranch,
commitMessageForStep,
input.commitFlags,
preResolvedCommitSuggestion,
input.filePaths,
);
Expand Down
1 change: 1 addition & 0 deletions apps/server/src/git/Services/GitCore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ export interface GitCoreShape {
cwd: string,
subject: string,
body: string,
extraArgs?: readonly string[],
) => Effect.Effect<{ commitSha: string }, GitCommandError>;

/**
Expand Down
2 changes: 1 addition & 1 deletion apps/web/public/mockServiceWorker.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* - Please do NOT modify this file.
*/

const PACKAGE_VERSION = '2.12.9'
const PACKAGE_VERSION = '2.12.10'
const INTEGRITY_CHECKSUM = '4db4a41e972cec1b64cc569c66952d82'
const IS_MOCKED_RESPONSE = Symbol('isMockedResponse')
const activeClientIds = new Set()
Expand Down
3 changes: 3 additions & 0 deletions apps/web/src/appSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ const AppSettingsSchema = Schema.Struct({
codexHomePath: Schema.String.check(Schema.isMaxLength(4096)).pipe(
Schema.withConstructorDefault(() => Option.some("")),
),
gitCommitFlags: Schema.String.check(Schema.isMaxLength(4096)).pipe(
Schema.withConstructorDefault(() => Option.some("")),
),
confirmThreadDelete: Schema.Boolean.pipe(Schema.withConstructorDefault(() => Option.some(true))),
enableAssistantStreaming: Schema.Boolean.pipe(
Schema.withConstructorDefault(() => Option.some(false)),
Expand Down
5 changes: 5 additions & 0 deletions apps/web/src/components/GitActionsControl.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import { Popover, PopoverPopup, PopoverTrigger } from "~/components/ui/popover";
import { ScrollArea } from "~/components/ui/scroll-area";
import { Textarea } from "~/components/ui/textarea";
import { toastManager } from "~/components/ui/toast";
import { useAppSettings } from "~/appSettings";
import { openInPreferredEditor } from "~/editorPreferences";
import {
gitBranchesQueryOptions,
Expand Down Expand Up @@ -158,6 +159,7 @@ export default function GitActionsControl({ gitCwd, activeThreadId }: GitActions
() => (activeThreadId ? { threadId: activeThreadId } : undefined),
[activeThreadId],
);
const { settings } = useAppSettings();
const queryClient = useQueryClient();
const [isCommitDialogOpen, setIsCommitDialogOpen] = useState(false);
const [dialogCommitMessage, setDialogCommitMessage] = useState("");
Expand Down Expand Up @@ -199,6 +201,7 @@ export default function GitActionsControl({ gitCwd, activeThreadId }: GitActions
useIsMutating({ mutationKey: gitMutationKeys.runStackedAction(gitCwd) }) > 0;
const isPullRunning = useIsMutating({ mutationKey: gitMutationKeys.pull(gitCwd) }) > 0;
const isGitActionRunning = isRunStackedActionRunning || isPullRunning;
const configuredCommitFlags = settings.gitCommitFlags.trim();
const isDefaultBranch = useMemo(() => {
const branchName = gitStatusForActions?.branch;
if (!branchName) return false;
Expand Down Expand Up @@ -349,6 +352,7 @@ export default function GitActionsControl({ gitCwd, activeThreadId }: GitActions
const promise = runImmediateGitActionMutation.mutateAsync({
action,
...(commitMessage ? { commitMessage } : {}),
...(configuredCommitFlags ? { commitFlags: configuredCommitFlags } : {}),
...(featureBranch ? { featureBranch } : {}),
...(filePaths ? { filePaths } : {}),
});
Expand Down Expand Up @@ -442,6 +446,7 @@ export default function GitActionsControl({ gitCwd, activeThreadId }: GitActions
},

[
configuredCommitFlags,
isDefaultBranch,
runImmediateGitActionMutation,
setPendingDefaultBranchAction,
Expand Down
3 changes: 3 additions & 0 deletions apps/web/src/lib/gitReactQuery.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,13 @@ export function gitRunStackedActionMutationOptions(input: {
mutationFn: async ({
action,
commitMessage,
commitFlags,
featureBranch,
filePaths,
}: {
action: GitStackedAction;
commitMessage?: string;
commitFlags?: string;
featureBranch?: boolean;
filePaths?: string[];
}) => {
Expand All @@ -132,6 +134,7 @@ export function gitRunStackedActionMutationOptions(input: {
cwd: input.cwd,
action,
...(commitMessage ? { commitMessage } : {}),
...(commitFlags ? { commitFlags } : {}),
...(featureBranch ? { featureBranch } : {}),
...(filePaths ? { filePaths } : {}),
});
Expand Down
43 changes: 43 additions & 0 deletions apps/web/src/routes/_chat.settings.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ function SettingsRouteView() {

const codexBinaryPath = settings.codexBinaryPath;
const codexHomePath = settings.codexHomePath;
const gitCommitFlags = settings.gitCommitFlags;
const keybindingsConfigPath = serverConfigQuery.data?.keybindingsConfigPath ?? null;
const availableEditors = serverConfigQuery.data?.availableEditors;

Expand Down Expand Up @@ -443,6 +444,48 @@ function SettingsRouteView() {
</div>
</section>

<section className="rounded-2xl border border-border bg-card p-5">
<div className="mb-4">
<h2 className="text-sm font-medium text-foreground">Git</h2>
<p className="mt-1 text-xs text-muted-foreground">
Configure extra flags for app-run <code>git commit</code> commands.
</p>
</div>

<div className="space-y-4">
<label htmlFor="git-commit-flags" className="block space-y-1">
<span className="text-xs font-medium text-foreground">
Extra git commit flags
</span>
<Input
id="git-commit-flags"
value={gitCommitFlags}
onChange={(event) => updateSettings({ gitCommitFlags: event.target.value })}
placeholder="--no-gpg-sign"
spellCheck={false}
/>
<span className="text-xs text-muted-foreground">
Applied to app-run git commit commands only. Example: <code>--no-gpg-sign</code>
. Quoted arguments are not supported yet.
</span>
</label>

<div className="flex justify-end">
<Button
size="xs"
variant="outline"
onClick={() =>
updateSettings({
gitCommitFlags: defaults.gitCommitFlags,
})
}
>
Restore default
</Button>
</div>
</div>
</section>

<section className="rounded-2xl border border-border bg-card p-5">
<div className="mb-4">
<h2 className="text-sm font-medium text-foreground">Responses</h2>
Expand Down
1 change: 1 addition & 0 deletions packages/contracts/src/git.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ export const GitRunStackedActionInput = Schema.Struct({
cwd: TrimmedNonEmptyStringSchema,
action: GitStackedAction,
commitMessage: Schema.optional(TrimmedNonEmptyStringSchema.check(Schema.isMaxLength(10_000))),
commitFlags: Schema.optional(TrimmedNonEmptyStringSchema.check(Schema.isMaxLength(4_096))),
featureBranch: Schema.optional(Schema.Boolean),
filePaths: Schema.optional(
Schema.Array(TrimmedNonEmptyStringSchema).check(Schema.isMinLength(1)),
Expand Down