Fixing inaccuracy regarding TTD adapter and HTTP/2#6499
Fixing inaccuracy regarding TTD adapter and HTTP/2#6499robhazan wants to merge 3 commits intoprebid:masterfrom
Conversation
TTD fully supports HTTP/2
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
robhazan
changed the title
All endpoints support HTTP/2. No need for a special flag.
| `banner` | optional | Display banner targeting parameters. See the banner section below. | `{}` | `object` | ||
| `bidfloor` | optional | Sets a bid floor price | `0.95` | `Float` | ||
| `customBidderEndpoint` | optional | Only set if TTD has provided a custom endpoint. If set the custom endpoint will take precedent over the hard-coded endpoints | `https://customBidderEndpoint/bid/bidder/` | `String` | ||
| `useHttp2` | optional | When true, the adapter will use an endpoint that supports HTTP2. | `true` | `boolean` |
There was a problem hiding this comment.
I don't see why this line should be removed.
https://github.com/prebid/Prebid.js/blob/1d8b5fe28c16b1965252839e27fcb9a9afc15312/modules/ttdBidAdapter.js#L284 still switches to a different endpoint when you set that param to true
There was a problem hiding this comment.
@robin-crazygames All of our endpoints support HTTP/2 now. So we no longer need to send traffic to some special endpoint for that. We don't want to break backwards compatibility for anyone who may be using this flag, but have no need for it anymore. So we figure just remove it from docs so nobody net new starts using it.
There was a problem hiding this comment.
Thanks for the explanation
|
@robin-crazygames do you have any idea what the linter doesn't like about the tables in this doc? |
|
I have no idea. I have an open PR that has the same problem, where the linter complains about tables I haven't touched. |
|
@robin-crazygames - are you the designated approver/reviewer this week? If so, anything else you need for approval? If not, do you know who is? |
|
@robhazan No, I'm just somebody who made a few contributions to the project (including the one that added that property you're about to remove). That is the only reason I dropped by on this PR |
2 participants
TTD fully supports HTTP/2. Updating the record to reflect this.
🏷 Type of documentation
📋 Checklist