-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixing inaccuracy regarding TTD adapter and HTTP/2 #6499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+21
−22
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
40785be
Fixing inaccuracy
robhazan d13df80
Removing useHttp2 flag
robhazan b46dc32
attempting to fix md linting issues
robhazan 52848b3
Update ttd.md
assertiverich efdfbaa
Add bid parameters section to TTD documentation
patmmccann 7a8db24
Update ttd.md
patmmccann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this line should be removed.
https://github.com/prebid/Prebid.js/blob/1d8b5fe28c16b1965252839e27fcb9a9afc15312/modules/ttdBidAdapter.js#L284 still switches to a different endpoint when you set that param to true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robin-crazygames All of our endpoints support HTTP/2 now. So we no longer need to send traffic to some special endpoint for that. We don't want to break backwards compatibility for anyone who may be using this flag, but have no need for it anymore. So we figure just remove it from docs so nobody net new starts using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: prebid/Prebid.js#14665