Draft: Fix #2155 - Streaming gzipped responses#7252
Draft
ReadingNought wants to merge 1 commit intopsf:mainfrom
Draft
Draft: Fix #2155 - Streaming gzipped responses#7252ReadingNought wants to merge 1 commit intopsf:mainfrom
ReadingNought wants to merge 1 commit intopsf:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable automatic content decoding on
Response.rawso streamed gzip-encoded responses can be consumed directly via file-like readers.Root Cause
Requests built responses with
raw.decode_content=False, so consumers reading fromresponse.rawgot compressed bytes by default. This breaks file-like streaming parsers that call.read()and expect decoded content.Changes Made
response.raw.decode_content = TrueinHTTPAdapter.build_response.tests/test_adapters.pyto verifybuild_responseenables decoded raw reads by default.Verification
PYTHONPATH=src pytest -q tests/test_adapters.py2 passedNotes
decode_content=Falseon read/stream calls.Closes #2155