Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions PR_BODY.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
## Summary
Enabled automatic content decoding on `Response.raw` so streamed gzip-compressed responses can be consumed through file-like readers.

## Root Cause
Requests built responses with `raw.decode_content` disabled, so consumers reading from `response.raw` received compressed bytes by default.

## Changes Made
- Set `response.raw.decode_content = True` in `HTTPAdapter.build_response`.
- Added a regression test in `tests/test_adapters.py` verifying that `build_response` enables decoded raw reads by default.

## Verification
- Ran `PYTHONPATH=src python3 -m pytest -q tests/test_adapters.py tests/test_requests.py -k "decompress_gzip or redirect_with_wrong_gzipped_header"`.
- Result: `2 passed, 332 deselected`.

## Notes
- Callers that need wire-level compressed bytes can still pass `decode_content=False` when reading from `response.raw`.
1 change: 1 addition & 0 deletions src/requests/adapters.py
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ def build_response(self, req, resp):
# Set encoding.
response.encoding = get_encoding_from_headers(response.headers)
response.raw = resp
response.raw.decode_content = True
response.reason = response.raw.reason

if isinstance(req.url, bytes):
Expand Down
14 changes: 14 additions & 0 deletions tests/test_adapters.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,17 @@ def test_request_url_trims_leading_path_separators():
a = requests.adapters.HTTPAdapter()
p = requests.Request(method="GET", url="http://127.0.0.1:10000//v:h").prepare()
assert "/v:h" == a.request_url(p, {})


def test_build_response_sets_decode_content():
adapter = requests.adapters.HTTPAdapter()
req = requests.Request(method="GET", url="http://example.com/").prepare()
raw_resp = type(
"RawResponse",
(),
{"status": 200, "headers": {}, "reason": "OK", "decode_content": False},
)()

response = adapter.build_response(req, raw_resp)

assert response.raw.decode_content is True