Avoid resolving packages unnecessarily #3366
Conversation
|
Now it's |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3366 +/- ##
====================================================
+ Coverage 99.98454% 100.00000% +0.01546%
====================================================
Files 128 128
Lines 19407 19407
Branches 1318 1318
====================================================
+ Hits 19404 19407 +3
+ Misses 1 0 -1
+ Partials 2 0 -2 🚀 New features to boost your workflow:
|
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
Always nice to have a time save
| flags="--skip-optional-imports" | ||
| else | ||
| python -m uv pip install -r test-requirements.txt | ||
| python -m uv pip install -r test-requirements.txt --no-deps |
There was a problem hiding this comment.
Warning
Depending on what's inside, this might produce different dependency trees on different platforms. And in some cases, deps might end up being missing (platform- or python-dependent ones etc).
There was a problem hiding this comment.
Yeah this is only fine because test-requirements.txt is a "universal" (i.e. made with uv pip compile --universal) lockfile. This could potentially break also if one of the packages changes deps without changing version but a) that's bad and b) well, we want the lockfile to contain everything anyways so erroring at some point is good.
3 participants
This really doesn't matter but
Resolved 72 packages in 1.13sin the CI logs really bothered me!