Skip to content

Avoid resolving packages unnecessarily #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
A5rocks wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Avoid resolving packages unnecessarily #3366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d38c71d
Avoid resolving packages unnecessarily
A5rocks Dec 5, 2025
8cab0b0
Merge branch 'main' into faster-uv
A5rocks Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ if [ "${NO_TEST_REQUIREMENTS-0}" == 1 ]; then
python -m uv pip install pytest coverage -c test-requirements.txt
flags="--skip-optional-imports"
else
python -m uv pip install -r test-requirements.txt
python -m uv pip install -r test-requirements.txt --no-deps
Copy link
Member

@webknjaz webknjaz Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Depending on what's inside, this might produce different dependency trees on different platforms. And in some cases, deps might end up being missing (platform- or python-dependent ones etc).

Copy link
Contributor Author

@A5rocks A5rocks Dec 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is only fine because test-requirements.txt is a "universal" (i.e. made with uv pip compile --universal) lockfile. This could potentially break also if one of the packages changes deps without changing version but a) that's bad and b) well, we want the lockfile to contain everything anyways so erroring at some point is good.

flags=""
fi

Expand Down