ci: update GitHub Actions to Node 24 before June 2 deadline#633
Conversation
📝 WalkthroughWalkthroughThis PR updates pinned GitHub Actions versions across four workflow files in the repository. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 zizmor (1.25.2).github/workflows/ci.ymlINFO zizmor: 🌈 zizmor v1.25.2 .github/workflows/python-tests.ymlINFO zizmor: 🌈 zizmor v1.25.2 ... [truncated 5154 characters] ...
.github/workflows/type-checkers.ymlINFO zizmor: 🌈 zizmor v1.25.2 ... [truncated 4204 characters] ... on-version }}\n uses: actions/setup-python@a309ff8 # v6.2.0\n with:\n python-version: ${{ matrix.python-version }}\n\n - name: Install dependencies\n run: |\n python -m pip install --upgrade pip poetry\n poetry install --no-interaction --no-ansi --without dev,docs,test\n\n - name: mypy\n run: |\n poetry run mypy fastembed \\n --disallow-incomplete-defs \\n --disallow-untyped-defs \\n --disable-error-code=import-untyped\n\n - name: pyright\n run: |\n poetry run pyright tests/type_stub.py",
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/ci.yml (1)
18-18:⚠️ Potential issue | 🟠 Major | ⚡ Quick winIncomplete Node 24 migration:
actions/cachestill on v3.5.0.According to the PR objectives,
actions/cacheshould be updated from v3–v4 to v5.0.5 to ensure Node 24 compatibility before the June 2, 2026 deadline. The current v3.5.0 version may break when Node 20 is removed from runners.🔄 Proposed fix
- - uses: actions/cache@6f8efc29b200d32929f49075959781ed54ec270c # v3.5.0 + - uses: actions/cache@1bd1e32a3bdc45362d1e726936510720a7c30a57 # v5.0.5🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/ci.yml at line 18, The workflow is still pinning actions/cache to v3.5.0 which prevents Node 24 compatibility; update the actions/cache usage (the line with "uses: actions/cache@...") to the v5 stable tag (actions/cache@v5.0.5) so the CI uses the Node-24-compatible cache action; verify no other workflow steps depend on v3 behavior and run the CI to confirm the update succeeds.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/workflows/ci.yml:
- Line 18: The workflow is still pinning actions/cache to v3.5.0 which prevents
Node 24 compatibility; update the actions/cache usage (the line with "uses:
actions/cache@...") to the v5 stable tag (actions/cache@v5.0.5) so the CI uses
the Node-24-compatible cache action; verify no other workflow steps depend on v3
behavior and run the CI to confirm the update succeeds.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 62c390b6-40f6-48f2-9dcc-2dfbf3ba2c76
📒 Files selected for processing (4)
.github/workflows/ci.yml.github/workflows/python-publish.yml.github/workflows/python-tests.yml.github/workflows/type-checkers.yml
Summary
GitHub will force all JavaScript-based actions to run on Node 24 starting June 2, 2026.
Node 20 will be removed from runners entirely on September 16, 2026.
Actions pinned to older versions (v1-v4 for checkout, v2-v5 for setup-python, etc.) were
written for Node 12/16/20 and risk breaking when forced to Node 24.
This PR updates all
actions/*references to the latest Node 24-native versions.Changes
All target SHAs verified against their tags via the GitHub API.
All target versions confirmed running
node24in theiraction.yml.References