Clean up pragmas and dead code in bksf.py#1240
Open
mhucka wants to merge 2 commits intoquantumlib:mainfrom
Open
Clean up pragmas and dead code in bksf.py#1240mhucka wants to merge 2 commits intoquantumlib:mainfrom
mhucka wants to merge 2 commits intoquantumlib:mainfrom
Conversation
Contributor
mhucka
commented
Mar 27, 2026
mhucka
commented
- Remove reachable # coverage: ignore and # pragma: no cover directives.
- Remove associated TODO comments.
- Remove unreachable dead code blocks to improve maintainability.
- Remove reachable # coverage: ignore and # pragma: no cover directives. - Remove associated TODO comments. - Remove unreachable dead code blocks to improve maintainability.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request cleans up the bksf.py file by removing coverage pragmas and redundant logic blocks in the bravyi_kitaev_fast_interaction_op and bravyi_kitaev_fast_edge_matrix functions. Specifically, it removes unnecessary coverage-related comments and unreachable conditional branches used when processing interaction operators. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.