Skip to content

Clean up pragmas and dead code in bksf.py #1240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhucka wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clean up pragmas and dead code in bksf.py #1240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
379dd09
Clean up pragmas and dead code in bksf.py
mhucka Mar 27, 2026
74b89dd
Merge branch 'main' into fix-bksf-code-health-3650992452040884433
mhucka Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/openfermion/transforms/opconversions/bksf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ def bravyi_kitaev_fast_interaction_op(iop: InteractionOperator) -> QubitOperator

# Skip zero terms.
if (not coefficient) or (p == q) or (r == s):
# coverage: ignore
continue

# Identify and skip one of the complex conjugates.
Expand All @@ -124,9 +123,6 @@ def bravyi_kitaev_fast_interaction_op(iop: InteractionOperator) -> QubitOperator
transformed_term *= 0.5 * coefficient
qubit_operator += transformed_term
continue
elif p != r and q < p:
# TODO: remove pragma if reachable continue
continue # pragma: no cover

# Handle the two-body terms.
transformed_term = _two_body(edge_matrix_indices, p, q, r, s)
Expand Down Expand Up @@ -169,16 +165,13 @@ def bravyi_kitaev_fast_edge_matrix(

# Skip zero terms.
if (not coefficient2) or (p == q) or (r == s):
# TODO: remove pragma if this is a reachable continue
continue # pragma: no cover
continue

# Identify and skip one of the complex conjugates.
if [p, q, r, s] != [s, r, q, p]:
if len(set([p, q, r, s])) == 4:
if min(r, s) < min(p, q):
continue
elif p != r and q < p:
continue

# Handle case of four unique indices.
if len(set([p, q, r, s])) == 4:
Expand Down
Loading